From 52b6a5b2a2b4c2f342cbee0474e64394e1ec0a21 Mon Sep 17 00:00:00 2001
From: "Mika Epstein (Ipstenu)" <ipstenu@halfelf.org>
Date: Thu, 20 Jun 2019 10:57:41 +0200
Subject: [PATCH 1/4] Document YodaConditionals you must

---
 WordPress/Docs/PHP/YodaConditionsStandard.xml | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 WordPress/Docs/PHP/YodaConditionsStandard.xml

diff --git a/WordPress/Docs/PHP/YodaConditionsStandard.xml b/WordPress/Docs/PHP/YodaConditionsStandard.xml
new file mode 100644
index 0000000000..484b419f88
--- /dev/null
+++ b/WordPress/Docs/PHP/YodaConditionsStandard.xml
@@ -0,0 +1,26 @@
+<documentation title="Yoda Conditional Statements">
+    <standard>
+    <![CDATA[
+      When doing logical comparisons involving variables, the variable must be placed on the right side. All constants, literals, and function calls must be placed on the left side. If neither side is a variable, the order is unimportant. 
+      
+For more information:
+https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions
+    ]]>
+    </standard>
+    <code_comparison>
+        <code title="The variable $the_force is placed on the right">
+        <![CDATA[
+if ( true === $the_force ) {
+    $victorious = you_will( $be );
+}
+        ]]>
+        </code>
+        <code title="The variable $the_force has been placed on the left">
+        <![CDATA[
+if ( $the_force === false ) {
+    $victorious = you_will_not( $be );
+}
+        ]]>
+        </code>
+    </code_comparison>
+</documentation>
\ No newline at end of file

From 41aa7d571645693f9a2deed46439a4bdafd8c2fd Mon Sep 17 00:00:00 2001
From: "Mika Epstein (Ipstenu)" <ipstenu@halfelf.org>
Date: Thu, 20 Jun 2019 12:01:36 +0200
Subject: [PATCH 2/4] requested fixes

---
 WordPress/Docs/PHP/YodaConditionsStandard.xml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/WordPress/Docs/PHP/YodaConditionsStandard.xml b/WordPress/Docs/PHP/YodaConditionsStandard.xml
index 484b419f88..c9fe1ee819 100644
--- a/WordPress/Docs/PHP/YodaConditionsStandard.xml
+++ b/WordPress/Docs/PHP/YodaConditionsStandard.xml
@@ -1,21 +1,21 @@
-<documentation title="Yoda Conditional Statements">
+<documentation title="Yoda Conditions">
     <standard>
     <![CDATA[
-      When doing logical comparisons involving variables, the variable must be placed on the right side. All constants, literals, and function calls must be placed on the left side. If neither side is a variable, the order is unimportant. 
+      When doing logical comparisons involving variables, the variable must be placed on the right side. All constants, literals, and function calls must be placed on the left side. If neither side is a variable, the order is unimportant.
       
 For more information:
 https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions
     ]]>
     </standard>
     <code_comparison>
-        <code title="The variable $the_force is placed on the right">
+        <code title="Valid: The variable $the_force is placed on the right">
         <![CDATA[
 if ( true === $the_force ) {
     $victorious = you_will( $be );
 }
         ]]>
         </code>
-        <code title="The variable $the_force has been placed on the left">
+        <code title="Invalid: The variable $the_force has been placed on the left">
         <![CDATA[
 if ( $the_force === false ) {
     $victorious = you_will_not( $be );

From 7acf3faaf0bf3ffc7b25e0ba435438b0d6b4c6f1 Mon Sep 17 00:00:00 2001
From: "Mika Epstein (Ipstenu)" <ipstenu@halfelf.org>
Date: Thu, 20 Jun 2019 13:34:30 +0200
Subject: [PATCH 3/4] End of line and whitespace

---
 WordPress/Docs/PHP/YodaConditionsStandard.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/WordPress/Docs/PHP/YodaConditionsStandard.xml b/WordPress/Docs/PHP/YodaConditionsStandard.xml
index c9fe1ee819..0b0fe17f3a 100644
--- a/WordPress/Docs/PHP/YodaConditionsStandard.xml
+++ b/WordPress/Docs/PHP/YodaConditionsStandard.xml
@@ -2,7 +2,7 @@
     <standard>
     <![CDATA[
       When doing logical comparisons involving variables, the variable must be placed on the right side. All constants, literals, and function calls must be placed on the left side. If neither side is a variable, the order is unimportant.
-      
+
 For more information:
 https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions
     ]]>
@@ -23,4 +23,4 @@ if ( $the_force === false ) {
         ]]>
         </code>
     </code_comparison>
-</documentation>
\ No newline at end of file
+</documentation>

From 76a82393f523bff4e77e2b5b2f19c9242f999c12 Mon Sep 17 00:00:00 2001
From: jrfnl <jrfnl@users.noreply.github.com>
Date: Mon, 16 May 2022 14:58:06 +0200
Subject: [PATCH 4/4] Docs/YodaConditions: minor fixes after review

---
 WordPress/Docs/PHP/YodaConditionsStandard.xml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/WordPress/Docs/PHP/YodaConditionsStandard.xml b/WordPress/Docs/PHP/YodaConditionsStandard.xml
index 0b0fe17f3a..169cbcc368 100644
--- a/WordPress/Docs/PHP/YodaConditionsStandard.xml
+++ b/WordPress/Docs/PHP/YodaConditionsStandard.xml
@@ -1,23 +1,23 @@
 <documentation title="Yoda Conditions">
     <standard>
     <![CDATA[
-      When doing logical comparisons involving variables, the variable must be placed on the right side. All constants, literals, and function calls must be placed on the left side. If neither side is a variable, the order is unimportant.
+    When doing logical comparisons involving variables, the variable must be placed on the right side. All constants, literals, and function calls must be placed on the left side. If neither side is a variable, the order is unimportant.
 
-For more information:
-https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions
+    For more information:
+    https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions
     ]]>
     </standard>
     <code_comparison>
-        <code title="Valid: The variable $the_force is placed on the right">
+        <code title="Valid: The variable is placed on the right">
         <![CDATA[
-if ( true === $the_force ) {
+if ( <em>true === $the_force</em> ) {
     $victorious = you_will( $be );
 }
         ]]>
         </code>
-        <code title="Invalid: The variable $the_force has been placed on the left">
+        <code title="Invalid: The variable has been placed on the left">
         <![CDATA[
-if ( $the_force === false ) {
+if ( <em>$the_force === false</em> ) {
     $victorious = you_will_not( $be );
 }
         ]]>