From 6bb0180b78ca540ad934897a95d7e199d1d1bc73 Mon Sep 17 00:00:00 2001
From: Richard Korthuis <richardkorthuis@acato.nl>
Date: Thu, 13 Jun 2024 11:05:40 +0200
Subject: [PATCH 1/3] Add documentation for
 WordPress.NamingConventions.ValidFunctionName

---
 .../ValidFunctionNameStandard.xml             | 119 ++++++++++++++++++
 1 file changed, 119 insertions(+)
 create mode 100644 WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml

diff --git a/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml b/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml
new file mode 100644
index 0000000000..64fd8e1a1a
--- /dev/null
+++ b/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml
@@ -0,0 +1,119 @@
+<?xml version="1.0"?>
+<documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+               xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
+               title="Valid Function Name"
+>
+    <standard>
+        <![CDATA[
+    Use lowercase letters in function names. Separate words using underscores. Do not use double underscores as a prefix.
+    ]]>
+    </standard>
+    <code_comparison>
+        <code title="Valid: lowercase function name.">
+            <![CDATA[
+prefix_function_name();
+        ]]>
+        </code>
+        <code title="Invalid: mixed case function name.">
+            <![CDATA[
+Prefix_Function_NAME();
+        ]]>
+        </code>
+    </code_comparison>
+    <code_comparison>
+        <code title="Valid: words separated by underscores.">
+            <![CDATA[
+prefix_function_name();
+        ]]>
+        </code>
+        <code title="Invalid: using camel case to separate words.">
+            <![CDATA[
+prefixFunctionName();
+        ]]>
+        </code>
+    </code_comparison>
+    <code_comparison>
+        <code title="Valid: function name with single underscore prefix.">
+            <![CDATA[
+_prefix_function_name();
+        ]]>
+        </code>
+        <code title="Invalid: function name with double underscore prefix.">
+            <![CDATA[
+__prefix_function_name();
+        ]]>
+        </code>
+    </code_comparison>
+    <code_comparison>
+        <code title="Valid: lower case method name.">
+            <![CDATA[
+$object->prefix_method_name();
+        ]]>
+        </code>
+        <code title="Invalid: mixed case method name.">
+            <![CDATA[
+$object->Prefix_Method_NAME();
+        ]]>
+        </code>
+    </code_comparison>
+    <code_comparison>
+        <code title="Valid: words separated by underscores.">
+            <![CDATA[
+$object->prefix_method_name();
+        ]]>
+        </code>
+        <code title="Invalid: using camel case to separate words.">
+            <![CDATA[
+$object->prefixMethodName();
+        ]]>
+        </code>
+    </code_comparison>
+    <code_comparison>
+        <code title="Valid: method name with single underscore prefix.">
+            <![CDATA[
+$object->_prefix_method_name();
+        ]]>
+        </code>
+        <code title="Invalid: method name with double underscore prefix.">
+            <![CDATA[
+$object->__prefix_method_name();
+        ]]>
+        </code>
+    </code_comparison>
+    <code_comparison>
+        <code title="Valid: lower case static method name.">
+            <![CDATA[
+My_Class::prefix_static_method_name();
+        ]]>
+        </code>
+        <code title="Invalid: mixed case static method name.">
+            <![CDATA[
+My_Class::Prefix_Static_Method_NAME();
+        ]]>
+        </code>
+    </code_comparison>
+    <code_comparison>
+        <code title="Valid: words separated by underscores.">
+            <![CDATA[
+My_Class::prefix_static_method_name();
+        ]]>
+        </code>
+        <code title="Invalid: using camel case to separate words.">
+            <![CDATA[
+My_Class::prefixStaticMethodName();
+        ]]>
+        </code>
+    </code_comparison>
+    <code_comparison>
+        <code title="Valid: static method name with single underscore prefix.">
+            <![CDATA[
+My_Class::_prefix_static_method_name();
+        ]]>
+        </code>
+        <code title="Invalid: static method name with double underscore prefix.">
+            <![CDATA[
+My_Class::__prefix_static_method_name();
+        ]]>
+        </code>
+    </code_comparison>
+</documentation>

From 3d855a26f41e9c6e0f45da9c64fc49ebf98af025 Mon Sep 17 00:00:00 2001
From: Richard Korthuis <richardkorthuis@acato.nl>
Date: Thu, 13 Jun 2024 12:05:06 +0200
Subject: [PATCH 2/3] Fix indentation

---
 .../ValidFunctionNameStandard.xml             | 42 +++++++++----------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml b/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml
index 64fd8e1a1a..14123106de 100644
--- a/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml
+++ b/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml
@@ -1,117 +1,117 @@
 <?xml version="1.0"?>
 <documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-               xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
-               title="Valid Function Name"
+    xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
+    title="Valid Function Name"
 >
     <standard>
-        <![CDATA[
+    <![CDATA[
     Use lowercase letters in function names. Separate words using underscores. Do not use double underscores as a prefix.
     ]]>
     </standard>
     <code_comparison>
         <code title="Valid: lowercase function name.">
-            <![CDATA[
+        <![CDATA[
 prefix_function_name();
         ]]>
         </code>
         <code title="Invalid: mixed case function name.">
-            <![CDATA[
+        <![CDATA[
 Prefix_Function_NAME();
         ]]>
         </code>
     </code_comparison>
     <code_comparison>
         <code title="Valid: words separated by underscores.">
-            <![CDATA[
+        <![CDATA[
 prefix_function_name();
         ]]>
         </code>
         <code title="Invalid: using camel case to separate words.">
-            <![CDATA[
+        <![CDATA[
 prefixFunctionName();
         ]]>
         </code>
     </code_comparison>
     <code_comparison>
         <code title="Valid: function name with single underscore prefix.">
-            <![CDATA[
+        <![CDATA[
 _prefix_function_name();
         ]]>
         </code>
         <code title="Invalid: function name with double underscore prefix.">
-            <![CDATA[
+        <![CDATA[
 __prefix_function_name();
         ]]>
         </code>
     </code_comparison>
     <code_comparison>
         <code title="Valid: lower case method name.">
-            <![CDATA[
+        <![CDATA[
 $object->prefix_method_name();
         ]]>
         </code>
         <code title="Invalid: mixed case method name.">
-            <![CDATA[
+        <![CDATA[
 $object->Prefix_Method_NAME();
         ]]>
         </code>
     </code_comparison>
     <code_comparison>
         <code title="Valid: words separated by underscores.">
-            <![CDATA[
+        <![CDATA[
 $object->prefix_method_name();
         ]]>
         </code>
         <code title="Invalid: using camel case to separate words.">
-            <![CDATA[
+        <![CDATA[
 $object->prefixMethodName();
         ]]>
         </code>
     </code_comparison>
     <code_comparison>
         <code title="Valid: method name with single underscore prefix.">
-            <![CDATA[
+        <![CDATA[
 $object->_prefix_method_name();
         ]]>
         </code>
         <code title="Invalid: method name with double underscore prefix.">
-            <![CDATA[
+        <![CDATA[
 $object->__prefix_method_name();
         ]]>
         </code>
     </code_comparison>
     <code_comparison>
         <code title="Valid: lower case static method name.">
-            <![CDATA[
+        <![CDATA[
 My_Class::prefix_static_method_name();
         ]]>
         </code>
         <code title="Invalid: mixed case static method name.">
-            <![CDATA[
+        <![CDATA[
 My_Class::Prefix_Static_Method_NAME();
         ]]>
         </code>
     </code_comparison>
     <code_comparison>
         <code title="Valid: words separated by underscores.">
-            <![CDATA[
+        <![CDATA[
 My_Class::prefix_static_method_name();
         ]]>
         </code>
         <code title="Invalid: using camel case to separate words.">
-            <![CDATA[
+        <![CDATA[
 My_Class::prefixStaticMethodName();
         ]]>
         </code>
     </code_comparison>
     <code_comparison>
         <code title="Valid: static method name with single underscore prefix.">
-            <![CDATA[
+        <![CDATA[
 My_Class::_prefix_static_method_name();
         ]]>
         </code>
         <code title="Invalid: static method name with double underscore prefix.">
-            <![CDATA[
+        <![CDATA[
 My_Class::__prefix_static_method_name();
         ]]>
         </code>

From 17d67d0a37c32f272616bc63cf042f9906aa94f9 Mon Sep 17 00:00:00 2001
From: Richard Korthuis <richardkorthuis@acato.nl>
Date: Thu, 13 Jun 2024 14:16:13 +0200
Subject: [PATCH 3/3] Function declaration instead of function usage

---
 .../ValidFunctionNameStandard.xml             | 96 ++-----------------
 1 file changed, 8 insertions(+), 88 deletions(-)

diff --git a/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml b/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml
index 14123106de..00b9bd4f2a 100644
--- a/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml
+++ b/WordPress/Docs/NamingConventions/ValidFunctionNameStandard.xml
@@ -11,108 +11,28 @@
     <code_comparison>
         <code title="Valid: lowercase function name.">
         <![CDATA[
-prefix_function_name();
+function <em>prefix_function_name()</em> {}
         ]]>
         </code>
         <code title="Invalid: mixed case function name.">
         <![CDATA[
-Prefix_Function_NAME();
+function <em>Prefix_Function_NAME()</em> {}
         ]]>
         </code>
     </code_comparison>
     <code_comparison>
         <code title="Valid: words separated by underscores.">
         <![CDATA[
-prefix_function_name();
+class My_Class {
+    public static <em>method_name()</em> {}
+}
         ]]>
         </code>
         <code title="Invalid: using camel case to separate words.">
         <![CDATA[
-prefixFunctionName();
-        ]]>
-        </code>
-    </code_comparison>
-    <code_comparison>
-        <code title="Valid: function name with single underscore prefix.">
-        <![CDATA[
-_prefix_function_name();
-        ]]>
-        </code>
-        <code title="Invalid: function name with double underscore prefix.">
-        <![CDATA[
-__prefix_function_name();
-        ]]>
-        </code>
-    </code_comparison>
-    <code_comparison>
-        <code title="Valid: lower case method name.">
-        <![CDATA[
-$object->prefix_method_name();
-        ]]>
-        </code>
-        <code title="Invalid: mixed case method name.">
-        <![CDATA[
-$object->Prefix_Method_NAME();
-        ]]>
-        </code>
-    </code_comparison>
-    <code_comparison>
-        <code title="Valid: words separated by underscores.">
-        <![CDATA[
-$object->prefix_method_name();
-        ]]>
-        </code>
-        <code title="Invalid: using camel case to separate words.">
-        <![CDATA[
-$object->prefixMethodName();
-        ]]>
-        </code>
-    </code_comparison>
-    <code_comparison>
-        <code title="Valid: method name with single underscore prefix.">
-        <![CDATA[
-$object->_prefix_method_name();
-        ]]>
-        </code>
-        <code title="Invalid: method name with double underscore prefix.">
-        <![CDATA[
-$object->__prefix_method_name();
-        ]]>
-        </code>
-    </code_comparison>
-    <code_comparison>
-        <code title="Valid: lower case static method name.">
-        <![CDATA[
-My_Class::prefix_static_method_name();
-        ]]>
-        </code>
-        <code title="Invalid: mixed case static method name.">
-        <![CDATA[
-My_Class::Prefix_Static_Method_NAME();
-        ]]>
-        </code>
-    </code_comparison>
-    <code_comparison>
-        <code title="Valid: words separated by underscores.">
-        <![CDATA[
-My_Class::prefix_static_method_name();
-        ]]>
-        </code>
-        <code title="Invalid: using camel case to separate words.">
-        <![CDATA[
-My_Class::prefixStaticMethodName();
-        ]]>
-        </code>
-    </code_comparison>
-    <code_comparison>
-        <code title="Valid: static method name with single underscore prefix.">
-        <![CDATA[
-My_Class::_prefix_static_method_name();
-        ]]>
-        </code>
-        <code title="Invalid: static method name with double underscore prefix.">
-        <![CDATA[
-My_Class::__prefix_static_method_name();
+class My_Class {
+    public static <em>methodName()</em> {}
+}
         ]]>
         </code>
     </code_comparison>