From 4424121d343aabee8473b32888eeb150933c6cde Mon Sep 17 00:00:00 2001
From: Xristopher Anderton <tikifez@users.noreply.github.com>
Date: Tue, 17 Sep 2024 10:53:29 -0700
Subject: [PATCH 1/5] Adds documentation for PregQuoteDelimiter

---
 WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml

diff --git a/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml b/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
new file mode 100644
index 000000000..d5aff1857
--- /dev/null
+++ b/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
@@ -0,0 +1,11 @@
+<?xml version="1.0"?>
+<documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+               xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
+               title="Preg Quote Delimiter"
+>
+    <standard>
+        <![CDATA[
+    Passing the $delimiter parameter to preg_quote() is strongly recommended to ensure the delimiter required by the PCRE functions are escaped.
+    ]]>
+    </standard>
+</documentation>

From 1ad4251de2ee2933bd567106aa546f6236157ca4 Mon Sep 17 00:00:00 2001
From: Xristopher Anderton <tikifez@users.noreply.github.com>
Date: Tue, 17 Sep 2024 11:26:17 -0700
Subject: [PATCH 2/5] Adds code comparison

---
 WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml b/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
index d5aff1857..595c21030 100644
--- a/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
+++ b/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
@@ -8,4 +8,17 @@
     Passing the $delimiter parameter to preg_quote() is strongly recommended to ensure the delimiter required by the PCRE functions are escaped.
     ]]>
     </standard>
+
+    <code_comparison>
+        <code title="Valid: The delimiter is included.">
+            <![CDATA[
+preg_quote( $str, '/' );
+        ]]>
+        </code>
+        <code title="Invalid: The delimiter is not included.">
+            <![CDATA[
+preg_quote( $str );
+        ]]>
+        </code>
+    </code_comparison>
 </documentation>

From 5265fff6b64b6ca6fba5624e055948ee72c662f2 Mon Sep 17 00:00:00 2001
From: Xristopher Anderton <tikifez@users.noreply.github.com>
Date: Tue, 17 Sep 2024 14:26:11 -0700
Subject: [PATCH 3/5] Updates spacing

---
 WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml b/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
index 595c21030..94b93c4f8 100644
--- a/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
+++ b/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
@@ -1,24 +1,23 @@
 <?xml version="1.0"?>
 <documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-               xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
-               title="Preg Quote Delimiter"
->
+    xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
+    title="Preg Quote Delimiter"
+    >
     <standard>
-        <![CDATA[
+    <![CDATA[
     Passing the $delimiter parameter to preg_quote() is strongly recommended to ensure the delimiter required by the PCRE functions are escaped.
     ]]>
     </standard>
-
     <code_comparison>
         <code title="Valid: The delimiter is included.">
-            <![CDATA[
+        <![CDATA[
 preg_quote( $str, '/' );
         ]]>
         </code>
         <code title="Invalid: The delimiter is not included.">
-            <![CDATA[
+        <![CDATA[
 preg_quote( $str );
         ]]>
         </code>
     </code_comparison>
-</documentation>
+</documentation>
\ No newline at end of file

From b2f9aaa55fff4296da85506cf4eb6dbe185090b0 Mon Sep 17 00:00:00 2001
From: Xristopher Anderton <tikifez@users.noreply.github.com>
Date: Tue, 17 Sep 2024 14:30:40 -0700
Subject: [PATCH 4/5] updated with responses to comments

---
 WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml b/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
index 94b93c4f8..e2683b767 100644
--- a/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
+++ b/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
@@ -5,7 +5,7 @@
     >
     <standard>
     <![CDATA[
-    Passing the $delimiter parameter to preg_quote() is strongly recommended to ensure the delimiter required by the PCRE functions are escaped.
+    Passing the $delimiter parameter to preg_quote() is strongly recommended. If it is not passed, the default delimiters `/` are presumed, which is often wrong.
     ]]>
     </standard>
     <code_comparison>

From a2371368e84aea3c049389dea74189d2fd20cb9b Mon Sep 17 00:00:00 2001
From: Xristopher Anderton <tikifez@users.noreply.github.com>
Date: Tue, 17 Sep 2024 14:34:52 -0700
Subject: [PATCH 5/5] updated example to use case from wordpress code

---
 WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml b/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
index e2683b767..4ac5870d8 100644
--- a/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
+++ b/WordPress/Docs/PHP/PregQuoteDelimiterStandard.xml
@@ -11,12 +11,12 @@
     <code_comparison>
         <code title="Valid: The delimiter is included.">
         <![CDATA[
-preg_quote( $str, '/' );
+preg_quote( $dir, '#' )
         ]]>
         </code>
         <code title="Invalid: The delimiter is not included.">
         <![CDATA[
-preg_quote( $str );
+preg_quote( $dir );
         ]]>
         </code>
     </code_comparison>