Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovering "holes" in certain areas of a block #10090

Closed
chrisvanpatten opened this issue Sep 21, 2018 · 2 comments
Closed

Hovering "holes" in certain areas of a block #10090

chrisvanpatten opened this issue Sep 21, 2018 · 2 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@chrisvanpatten
Copy link
Member

Because of the way we construct block UI, there are certain areas of the block where hovering doesn't actually trigger the intended result.

For instance, the movers are intended to display when you have the left side of the block hovered (I think it's like 30% or something). But it doesn't always work as illustrated by this annoyingly large GIF…

recording-62

When a block is not selected, hovering in these areas also causes the dark hover border to go away. I didn't GIF that, but you can try it on your own.

In this crude illustration, you can see a bit how this happens. The blue areas show where hover is correctly triggered.

screen_shot_2018-09-21_at_08_03_04_pxd

The other areas don't work because our block border area (what I'll call the block "canvas") is drawn with a pseudo-element that has pointer-events: none applied. This means hover (and click) events don't trigger there.

@chrisvanpatten chrisvanpatten added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels Sep 21, 2018
@designsimply
Copy link
Member

I tested with WordPress 4.9.8 and Gutenberg 4.0 using Firefox 62.0.3 on macOS 10.13.6 and hovering any part of the left of the block results in the movers showing up as expected.

@chrisvanpatten would you be willing to have another look with 4.0 (just released) and we can re-open if needed? If you're still having trouble, would you mind also noting your OS and browser versions?

@chrisvanpatten
Copy link
Member Author

Just following up on this — it is indeed fixed; the insertion point CSS has changed to go the full width of the block. Not sure when it changed, but it did!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants