Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Welcome" tip dismissal uses local storage, requiring a new dismissal for every new device and browser #10742

Closed
JJJ opened this issue Oct 18, 2018 · 2 comments
Labels
[Feature] NUX Anything that impacts the new user experience [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.

Comments

@JJJ
Copy link
Contributor

JJJ commented Oct 18, 2018

When adding or editing a post for the first time, Gutenberg shows a big weird blocking tip thing. Aside from the relatively confusing look and disconnected styling of the thing, it's also per-device and per-browser, so every new visit to Gutenberg requires acknowledgement and dismissal of the same obtrusive thing before I can do anything.

To Reproduce

  1. Open your favorite browser and navigate to a newish install
  2. Login, and head to WP Admin
  3. Click "Add New" Post via your favourite route
  4. See the tip with the blue throbber (screenshot below)
  5. Click "X" to dismiss the tip
  6. Open a different browser, or go into Incognito/Private mode
  7. Repeat steps 2 through 4
  8. See the tip again, even though you dismissed it

Expected behavior
Tips like these should not use local storage. They should be persistent across sessions, and belong in the database, so users are not required to re-dismiss something repeatedly across all devices.

Screenshots
screen shot 2018-10-18 at 9 32 22 am

screen shot 2018-10-18 at 9 33 07 am

screen shot 2018-10-18 at 9 33 52 am

Desktop (please complete the following information):

  • OS: macOS (10.14)
  • Browser Any (any)

Additional context

  • Gutenberg 4.0.0
@Soean
Copy link
Member

Soean commented Oct 18, 2018

Related to #8052

@Soean Soean added [Type] Enhancement A suggestion for improvement. [Feature] NUX Anything that impacts the new user experience labels Oct 18, 2018
@Soean
Copy link
Member

Soean commented Oct 18, 2018

Thanks for reporting @JJJ, I close this one as duplicate of #8052. It covers this issue and related problems of storing user settings for the editor.

@Soean Soean closed this as completed Oct 18, 2018
@Soean Soean added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] NUX Anything that impacts the new user experience [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants