Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery should be nested image blocks #11849

Closed
spacedmonkey opened this issue Nov 14, 2018 · 2 comments · Fixed by #25940
Closed

Gallery should be nested image blocks #11849

spacedmonkey opened this issue Nov 14, 2018 · 2 comments · Fixed by #25940
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] Needs More Info Follow-up required in order to be actionable. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@spacedmonkey
Copy link
Member

The gallery block, should be a series of nested image blocks. This makes the implementation clearer and easy to manage.
@designsimply designsimply added Needs Design Feedback Needs general design feedback. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable [Block] Gallery Affects the Gallery Block - used to display groups of images labels Nov 14, 2018
@designsimply
Copy link
Member

I am not sure nested image blocks make sense. Could you explain a bit more about why you think a gallery as nested image blocks makes the implementation easier to manage from your point of view? I'm also interested in whether you're coming from an end user perspective or a developer perspective (both are good perspectives, I want to know which you're thinking of and specifics around use cases and whys).

@designsimply designsimply added the [Status] Needs More Info Follow-up required in order to be actionable. label Nov 14, 2018
@karmatosed
Copy link
Member

I don't see how nested blocks helps this, happy to be given more insight though. For now closing this but we can always reopen.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Nov 21, 2018
@paaljoachim paaljoachim mentioned this issue Apr 22, 2019
Closed
This was referenced Mar 23, 2021
Closed
Merged
@priethor priethor linked a pull request Mar 23, 2021 that will close this issue
Gallery: Convert Gallery block to use Image blocks instead of having its own nested image format #25940
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] Needs More Info Follow-up required in order to be actionable. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
Projects
None yet
Milestone
No milestone
3 participants
@spacedmonkey @karmatosed @designsimply