Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider having a "pressed" or "active" state on buttons that trigger popovers #11937

Closed
mtias opened this issue Nov 15, 2018 · 1 comment
Closed
Labels
[Feature] UI Components Impacts or related to the UI component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels.
Milestone

Comments

@mtias
Copy link
Member

mtias commented Nov 15, 2018

Right now focus switches to the popover (or sidebar) and the item that opened it is only indicated by an arrow (in the case of dropdown menus).

Would be good to consider a visual display that more clearly communicates something is toggled, without messing with focus flow.

@mtias mtias added this to the Future: 5.1 milestone Nov 15, 2018
@mtias mtias added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. [Feature] UI Components Impacts or related to the UI component system labels Nov 15, 2018
@youknowriad
Copy link
Contributor

Is this something that you still consider? Should we just close to issue in favor of all the redesigns in #18667

@mtias mtias closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

No branches or pull requests

2 participants