-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gutenberg references from block-library PHP files #12085
Comments
Are there plans to deprecate those functions or will they be removed completely? Lots of juggling of “what’s active” (plugin version vs core version) already, and removing these functions only makes things more difficult for plugins and themes built against the Gutenberg plugin over the last year. |
@spencerfinnell: Do you have a use case for when you're relying on these particular functions? |
I don’t have a specific use case but completely removing (renaming) functions a week before release doesn’t fit with the deprecation schedule that has been used for JavaScript functions/APIs. |
Has there been any discussion about prefixing the names of the new global functions with |
Nope just this ticket 6 days before 33% of the web changes. |
There are just two functions inside of one file block-library/latest-comments/index.php Looking at the code, one of the functions was copied out of core because it could not be used included during rendering. The other function is used to render the latest comments block. Both seem pretty unlikely they'd be called outside of latest-comments block |
We now have both There's also |
When I grep |
The PHP files in
block-library
are copied to Core and committed there, but they're going to be maintained in this repo for now.To fit in properly with core, there are a couple of changes to make:
@package gutenberg
should become@package WordPress
.gutenberg_
function prefixes should be removed.#10788 is related, for removing the
'gutenberg'
textdomain from these files.The text was updated successfully, but these errors were encountered: