Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color selection icon to caption toolbar #12282

Closed
paaljoachim opened this issue Nov 25, 2018 · 8 comments
Closed

Add color selection icon to caption toolbar #12282

paaljoachim opened this issue Nov 25, 2018 · 8 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

Is your feature request related to a problem? Please describe.
One needs to add CSS to be able to adjust the color of the caption.

screen shot 2018-11-25 at 09 25 54

Describe the solution you'd like
I would like to see a color select icon in the caption toolbar. Perhaps something like this:

gutenberg-color-caption-option

Describe alternatives you've considered
Figuring out the caption css and then modifying that with the color I want to use for the caption.

@swissspidy
Copy link
Member

Not sure how common that use case is, but color settings are usually in the block sidebar. So in this case it could be added there as well.

@swissspidy swissspidy added [Type] Enhancement A suggestion for improvement. [Block] Gallery Affects the Gallery Block - used to display groups of images labels Nov 25, 2018
@paaljoachim
Copy link
Contributor Author

paaljoachim commented Nov 25, 2018

Yup, color for affecting the background and the text is in the sidebar.
I was thinking that for smaller cases such as a caption for single image and gallery captions (I am also thinking that other cases will show up) could be added directly into the caption toolbar. As the caption toolbar has the direct affect on the caption and is very localized just above it.

Use case is wanting another color for the caption text.

EDIT: Rephrasing...
I can not really think of any other block that has another toolbar inside it as the single image and gallery has for the caption toolbar. The caption toolbar can easily be adjusted for added features.
Not sure if that really clears up anything, as I am not finding the correct words to use I guess...:)

@ellatrix
Copy link
Member

For now you can use https://wordpress.org/plugins/advanced-rich-text-tools/.

@paaljoachim
Copy link
Contributor Author

Thanks Ella!

@ellatrix
Copy link
Member

ellatrix commented Feb 8, 2019

Closing as there are no plans of adding this by default in core. This issue is also a duplicate of #10225.

@ellatrix ellatrix closed this as completed Feb 8, 2019
@phpbits
Copy link
Contributor

phpbits commented May 17, 2019

@paaljoachim I've added text highlighting color options on EditorsKit plugin ( https://wordpress.org/plugins/block-options/ ) which is also working perfectly on captions. Here's how my implementation works :

Gutenberg Highlighted Text and Background Colors

@paaljoachim
Copy link
Contributor Author

That sounds very cool Jeffrey!

@phpbits
Copy link
Contributor

phpbits commented May 21, 2019

Thanks @paaljoachim! Really glad you like it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants