Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Enable a disabled fragile link e2e test #13044

Closed
gziolo opened this issue Dec 20, 2018 · 3 comments · Fixed by #13161
Closed

Tests: Enable a disabled fragile link e2e test #13044

gziolo opened this issue Dec 20, 2018 · 3 comments · Fixed by #13161
Assignees
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Comments

@gziolo
Copy link
Member

gziolo commented Dec 20, 2018

In #13043 allows autocomplete suggestions to be selected with the mouse test from links spec was disabled because it was failing too often on Travis.

When it fails, this is what is printed on the console:

FAIL test/e2e/specs/links.test.js (57.317s)
● Links › allows autocomplete suggestions to be selected with the mouse
expect(received).not.toBeNull()
Received: null
300 | // Expect that clicking on the autocomplete suggestion doesn't dismiss the link popover.
301 | await firstSuggestion.click();
> 302 | expect( await page.$( '.editor-url-popover' ) ).not.toBeNull();
| ^
303 |
304 | // Expect the url input value to have been updated with the post url.
305 | const inputValue = await page.evaluate( () => document.querySelector( '.editor-url-input input[aria-label="URL"]' ).value );
at Object.toBeNull (test/e2e/specs/links.test.js:302:55)
at tryCatch (node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:288:22)
at Generator.prototype.(anonymous function) [as next] (node_modules/regenerator-runtime/runtime.js:114:21)
at asyncGeneratorStep (test/e2e/specs/links.test.js:15:103)
at _next (test/e2e/specs/links.test.js:17:194)

In my tests, it didn't regress. It would be nice to discover why this test doesn't work as intended with Puppeteer.

/cc @talldan

@gziolo gziolo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Dec 20, 2018
@talldan
Copy link
Contributor

talldan commented Dec 21, 2018

I had a look at it last week, but haven't been able to understand what's causing it. As you say, the feature seems to be working ok, and the test logic looks ok to me.

I'll take a look again next week.

@talldan talldan self-assigned this Dec 21, 2018
@talldan talldan mentioned this issue Jan 2, 2019
5 tasks
@talldan
Copy link
Contributor

talldan commented Jan 3, 2019

I've been testing on CI since I haven't been able reproduce locally, and I've only managed to make the e2e tests with plugins fail so far, so it could be that a plugin is causing an actual issue. Next step, try to determine if that's actually the case and which plugin it might be.

edit: ugh, no, I just managed to trigger the failure in the non-plugins test as well ☹️

@gziolo
Copy link
Member Author

gziolo commented May 9, 2019

It was disabled again in #15059. It's now tracked in #15538.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants