Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image title attribute #13311

Closed
Markmcl opened this issue Jan 14, 2019 · 5 comments
Closed

Image title attribute #13311

Markmcl opened this issue Jan 14, 2019 · 5 comments
Labels
[Block] Image Affects the Image Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@Markmcl
Copy link

Markmcl commented Jan 14, 2019

The ability to enter or edit an Image Title Attribute is missing in the Gutenberg image block.

Do not confuse this with either the Image Title or Alternative Text.
This problem is well described at https://wordpress.org/support/topic/gutenberg-image-block-missing-image-title-attribute-field/

@Soean Soean added [Block] Image Affects the Image Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Jan 14, 2019
@Soean
Copy link
Member

Soean commented Jan 14, 2019

We already have an open issue about this missing feature #11054, so I am ging to close this one as a duplicate.

@Soean Soean closed this as completed Jan 14, 2019
@Markmcl
Copy link
Author

Markmcl commented Jan 14, 2019

I disagree, the only place " Image Title Attribute" is mentioned, (pardon me if I have misread, but I don't think I have) in #11054 is in the second last para from bmeachamand and perhaps the last para and are clearly not what the rest of the posts on that page are about.

That issue is clearly entitled "Image block: allow for editing image title " and I say in my second line above "Do not confuse this with either the Image Title or Alternative Text." which is what the other issue is about.
Could you please change this back to "open"
My issue is to restate it
"The ability to enter or edit an Image Title Attribute is missing in the Gutenberg image block."

@Soean
Copy link
Member

Soean commented Jan 14, 2019

Sorry for the confusion. This issue is about the global title attribute right?
Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title
Example: <img title="xyz" src="..." alt>`

The PR linked in that issue is exactly doing this: #11070

@Markmcl
Copy link
Author

Markmcl commented Jan 14, 2019

yes, & your link led to some interesting reading at https://inclusive-components.design/tooltips-toggletips/
which makes me think perhaps Title Attributes should be left when you think about the associated accessibility problems.
Care is needed and attention paid to his conclusions and checklist at the end of the article if they were to be implemented.

I have always set title attributes on menu items to give a tooltip on hover without thinking about accessibility and was worried tooltips would not be available when menus are converted to blocks, but when you read that article perhaps they just are not needed.

@FinnJackson
Copy link

Please restore 'Image Title Attribute' in the Gutenberg editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

3 participants