-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to use text link instead of auto embed. #15102
Comments
Thanks for opening the issue, this was discussed during the triage session today https://wordpress.slack.com/archives/C02QB2JS7/p1555939888308300 Based on these discussions, we propose to add a block transform to transform embed blocks to paragraph blocks but we should create |
Hello Jorge. @jorgefilipecosta Adding a link should have consistency. When a link is suddenly embedded and looks different then other links then that can create frustration. When a link wants to embed itself so that it shows different then a standard text link then the default placeholder box should show up asking if one wants to embed the link. |
The paste-a-link-to-embed functionality here is the same as other embed blocks, so I think the block transform to paragraph makes sense as a first step here. |
With #14776, the Undo action can now be used to cancel an automated transform (e.g. when a user types This leads me to ask: in this issue, instead of adding explicit transforms, shouldn't we extend this UX pattern so that Undo can also "revert" the addition of an embed and just leave the untouched URL? /cc @ellatrix |
That sounds reasonable. I'm not sure how discoverable it will be, but I do think it makes senses to do. |
Cross-linking related requests from the Gutenberg plugin forum: |
Cross-posting the content from a duplicated issue #16159:
|
Could we combine the undo behaviour with a timely snackbar notice? "So and so happened. Press Meta + Z to Undo." |
It would be great with some feedback on this issue, so we can move it onward in finding a good solution. |
I went and made a bug report showing how embedding works in Gutenberg 7.7.1: |
I've updated #17413. It may solve this issue. |
A snackbar notice is going to be easily missed until/unless everyone is 'trained' to know that's where to look for messages. Also 'undo' implies that the user did something wrong, which is not the case here. In this case, a better idea would be to have a 'hoverable' action. For example, on Helpscout, if I paste in a link it automatically makes a link. If I hover over it, it lets me chose 'edit' or 'unlink' -- this tells me
That makes it more clear to everyone that it's not 'wrong' (which is what undo implies) but just a choice. |
Thanks for weighing in.
I agree that there is an important drawback there. That kind of interaction is foreign to WordPress. However, it's still noteworthy that many important applications out there are using this model: Gmail allows undoing deletions and other motions via identical "snack bars"; Slack now notifies the user after markdown-style content is pasted, offering to convert it to rich text. This doesn't mean WordPress needs to follow suit, but they are relevant examples.
This one I'd argue against, for two main reasons:
|
If it requires hovering, what makes this feature discoverable? Could we apply that to Gutenberg? |
Oh I promise you, having ‘undo’ work like it does has resulted in a lot of “what did I do wrong/bad!?” from users |
So the process should be... EDIT: Reasons: The user is in control of how a link is seen on the backend and frontend. |
Is your feature request related to a problem? Please describe.
Adding links. If an link goes to another WordPress site we will see an auto embed such as this:
A mix of auto embeds and text links.
Describe the solution you'd like
I would like the option to include an auto embed OR a text link. As some links above are automatically embedded showing an article preview while other links just show a text link.
Describe alternatives you've considered
I added the following code from my tutorial here:
https://easywebdesigntutorials.com/adjusting-the-auto-embeds-of-wordpress-site-links-on-your-site/
By adding code from the above tutorial it forces the link dialog box to open for the links that were auto embedded. I can then select to convert the auto embeds to regular text links. One should not need to add the code to turn off auto embeds.
The text was updated successfully, but these errors were encountered: