Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylesheet docs to packages which ship styles #15253

Open
iandunn opened this issue Apr 29, 2019 · 3 comments
Open

Add stylesheet docs to packages which ship styles #15253

iandunn opened this issue Apr 29, 2019 · 3 comments
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.

Comments

@iandunn
Copy link
Member

iandunn commented Apr 29, 2019

In #15241 @gziolo said:

It seems like a great idea to add [documentation on enqueuing package styles]. I'm wondering whether we should add a similar note to all packages which also ship styles like block-library or format-library.

Maybe that can be automated by the docs:build script?

@iandunn iandunn added [Type] Enhancement A suggestion for improvement. [Type] Developer Documentation Documentation for developers [Type] Build Tooling Issues or PRs related to build tooling labels Apr 29, 2019
@gziolo
Copy link
Member

gziolo commented Apr 29, 2019

@nosolosw, do you think it’s something which can be automated or should we add it manually to those packages which ship CSS files?

@oandregal
Copy link
Member

do you think it’s something which can be automated or should we add it manually to those packages which ship CSS files?

I lack specific knowledge to address this at the moment (Which are those packages? Are there many? How can we identify them?). Reading through #15241 and skimming through code my understanding is that there are only a couple of them and this doesn't change often. With that assumption I'd update docs manually.

@DaisyOlsen
Copy link
Contributor

Is this still relevant? Can it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants