Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient color contrast on block type buttons #15271

Closed
karlgroves opened this issue Apr 30, 2019 · 2 comments
Closed

Insufficient color contrast on block type buttons #15271

karlgroves opened this issue Apr 30, 2019 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@karlgroves
Copy link

Insufficient color contrast on block type buttons

  • Severity: Medium
  • Affected Populations:
    • Low-Vision
    • Cognitively Impaired
  • Platform(s):
    • All / Universal
  • Components affected:
    • Empty Block

Issue description

Three Block type buttons are implemented with very light gray SVG
elements, the contrast ratio of which is below the minimum threshold of
3:1 for interface components:

  • #c9d0d5 (ash grey) on #fff (white): 1.6:1

Sufficient color contrast is important for users who have low-vision or
are color-blind, because text with a low contrast ratio may be difficult
or impossible for such users to see.

Issue Code
    .editor-inserter-with-shortcuts__block {
        ...
        color: rgba(102,120,134,.35);
    }

#### Remediation Guidance

The SVG elements inherit their `fill` color from parent `<span>`
elements, via `currentColor`.

Therefore the parent color needs to be darkened to meet the 3:1 minimum
contrast ratio. The button border remaining light grey before user
interaction, combined with the even darker hover/focus color plus the
visible tooltip, will ensure that the difference between default and
interacted elements is still clearly visible.

##### Recommended Code

.editor-inserter-with-shortcuts__block {
    ...
    color: rgba(102,120,134,.8);
}

Relevant standards

Note: This issue may be a duplicate with other existing accessibility-related bugs in this project. This issue comes from the Gutenberg accessibility audit, performed by Tenon and funded by WP Campus. This issue is GUT-89 in Tenon's report

@gziolo gziolo added the Needs Accessibility Feedback Need input from accessibility label Apr 30, 2019
@mapk
Copy link
Contributor

mapk commented May 2, 2019

Thanks! It appears this issue is a duplicate of another one already resolved [#12928].

I'm closing this as it's already fixed.

@mapk mapk closed this as completed May 2, 2019
@mapk mapk added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label May 2, 2019
@gziolo gziolo added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed Needs Accessibility Feedback Need input from accessibility labels May 4, 2019
@afercia
Copy link
Contributor

afercia commented May 8, 2019

For history, here's the screenshot from the WPCampus full report:

Screenshot 2019-05-08 at 19 03 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

4 participants