Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Pinned Plugins button styles when toggled #15608

Closed
afercia opened this issue May 13, 2019 · 1 comment · Fixed by #15609
Closed

Fix the Pinned Plugins button styles when toggled #15608

afercia opened this issue May 13, 2019 · 1 comment · Fixed by #15609
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented May 13, 2019

After the changes to the header Settings button in #14475 (my bad) the Pinned Plugins button styles are broken when the button is toggled:

  • the different left margin makes the buttons "jump"
  • colors of the SVG icon are inverted

The Settings button and the Pinned Plugins button inherit some common styles from packages/edit-post/src/components/header/style.scss but then the Pinned Plugins one has a few specific rules that need to be updated after the changes in #14475.

To reproduce:

  • install a plugin that provides its own Sidebar
  • open the Plugin sidebar from the More menu
  • click the "Pin to toolbar" button in the plugin Sidebar
  • observe the pinned button styles when clicking on ti

Animated GIF:

toggle

@afercia afercia added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels May 13, 2019
@simison
Copy link
Member

simison commented Aug 19, 2019

This got reported here too Automattic/jetpack#13212 (comment)

Looked broken in Gutenberg 6.2.0 and 6.3.0 — this should be fixed in future versions, correct?

From a quick glance it looked like these margin styles are conflicting & causing the jump:

.edit-post-header .components-button {
// Header toggle buttons.
&.is-toggled {
color: $white;
background: $dark-gray-500;
margin: 1px;

.components-icon-button {
margin-left: 4px;

— but I didn't look closer so I might be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants