Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual queues for Edit and Navigation Mode #17184

Closed
talldan opened this issue Aug 26, 2019 · 12 comments
Closed

Visual queues for Edit and Navigation Mode #17184

talldan opened this issue Aug 26, 2019 · 12 comments
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@talldan
Copy link
Contributor

talldan commented Aug 26, 2019

Is your feature request related to a problem? Please describe.
Recently while using the editor I've been thinking about the new Edit and Navigation mode (#16500), and what it's like for users using the editor for the first time.

What does it mean when my block is highlighted with a blue border? My feeling is that it's ok if you're a mouse user, clicking on the block allows you to edit it.

If you're someone who primarily uses only the keyboard (as I quite often do), then I'm concerned that it might not be clear why nothing happens when attempting to type in a block in nav mode.

Describe the solution you'd like
One way to remedy this could be using tips. I think first and foremost, if a user finds themselves in navigation mode, it'd be great to show some kind of tip that tells them how to get back into edit mode.

Here's a little example of what this could look like to get the ball rolling:
Screen Shot 2019-08-26 at 1 14 43 pm

If this seems too noisy, one option could be that the tip only appears if the user tries typing.

Describe alternatives you've considered
Perhaps typing should switch back into edit mode? This would rule out my other idea - #17185

@talldan talldan added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Aug 26, 2019
@karmatosed
Copy link
Member

That's actually a pretty valid query, it does look like it becomes an input. I wonder what it would feel like but that of makes sense. Focus, then edit.

@joedolson
Copy link
Contributor

From an accessibility & a usability standpoint, having a clearly articulated text statement that indicates the current state of the block and instructs the user how to change that state is extremely helpful.

@wittwitsan
Copy link
Member

In design triage in slack, we agreed some kind of cue is needed. Finding a general way to enable tips/help mode similar to Gmail for compact/expanded display or another way might help.

@mapk
Copy link
Contributor

mapk commented May 19, 2020

We need some design work here to figure this out.

  • Is this a snackbar notification? What wording will be used?
  • @paaljoachim mentioned just dropping the user into Edit mode when they start typing. How does that feel?

@mapk mapk added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels May 19, 2020
@paaljoachim
Copy link
Contributor

paaljoachim commented May 20, 2020

Today Select Mode changes to the Edit Mode on double clicking a block or pressing Enter.
Select Mode could also change to Edit Mode when the user begins to write. As it gives a signal that the user wants to interact with the block.

@mapk
Copy link
Contributor

mapk commented May 26, 2020

If you're someone who primarily uses only the keyboard (as I quite often do), then I'm concerned that it might not be clear why nothing happens when attempting to type in a block in nav mode.

@talldan, is the process of selecting to enter Select mode enough of an indicator as to why the blocks are now blue?

@talldan
Copy link
Contributor Author

talldan commented May 27, 2020

@mapk It's also triggered using the Escape key, which is something that is often reflexively pressed. Once Escape is pressed there's not much indication of what the change in mode means.

@paaljoachim mentioned just dropping the user into Edit mode when they start typing. How does that feel?

I think it could be worth trying something along those lines.

@mapk
Copy link
Contributor

mapk commented Jul 16, 2020

Another option is when entering the Select mode using the Esc key display a snackbar notification, and vice-versa.

When using the Esc key to enter Select mode

snackbar

When using the Enter key to enter Edit mode

snackbar2

@mapk mapk added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Jul 16, 2020
@paaljoachim
Copy link
Contributor

I see there has been no movement here for a while.
@jasmussen Joen I thinking you might want to also give some feedback here?

@jasmussen
Copy link
Contributor

The snackbar to indicate tool shift seems fine to try, but I'd massage the text if we can:

  • While it's technically a mode shift, so is it a mode shift when you choose the marquee tool in Photoshop, and the term "mode" seems technical and unhelpful as there's nothing intrinsic about that word that explains what's going on.
  • To go back to editing text, you can also click again on a block already selected. Or you can choose the tool from the toolbar.
  • Since editing is default and in use most of the time, we can probably keep that phrase simpler.

I'd welcome copy suggestions, but here's a quick stab:

  1. Now selecting blocks. Click twice or press Enter to edit.
  2. Now editing text.

@hedgefield
Copy link

The snackbar still feels a little ephemeral, but it's a good improvement over what we have now, so I'd vote for trying this out too. I also like the idea of automatically switching based on certain inputs.

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Nov 4, 2020
@mtias mtias removed the Needs Dev Ready for, and needs developer efforts label Jul 13, 2021
@talldan
Copy link
Contributor Author

talldan commented Mar 9, 2023

Closing this as stale. The issue is fairly old and never gained any clear direction.

@talldan talldan closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

9 participants