Fixing up StrictMode errors in the e2e tests. #17355

pento · 2019-09-06T04:55:54Z

Blocks #14845.

Describe the bug

Turning on StrictMode gives a bunch of errors, this is a tracking ticket to list them out.

I'll list one per comment, along with an e2e test that generates the error.

To reproduce

Run the e2e tests with SCRIPT_DEBUG set to true.

The text was updated successfully, but these errors were encountered:

pento · 2019-09-06T04:57:16Z

Test: npm run test-e2e packages/e2e-tests/specs/links.test.js

Links › can be created by selecting text and using keyboard shortcuts

    expect(jest.fn()).not.toHaveErrored(expected)

    Expected mock function not to be called but it was called with:
    ["Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in %s.%s the componentWillUnmount method 
        in URLInput
        in Unknown (created by WithSelect(URLInput))
        in WithSelect(URLInput) (created by WithInstanceId(WithSelect(URLInput)))
        in WithInstanceId(WithSelect(URLInput)) (created by WithSpokenMessages(WithInstanceId(WithSelect(URLInput))))
        in WithSpokenMessages(WithInstanceId(WithSelect(URLInput))) (created by WithSafeTimeout(WithSpokenMessages(WithInstanceId(WithSelect(URLInput)))))
        in WithSafeTimeout(WithSpokenMessages(WithInstanceId(WithSelect(URLInput)))) (created by LinkEditor)
        in form (created by LinkEditor)
        in LinkEditor (created by InlineLinkUI)
        in div (created by URLPopover)
        in div (created by URLPopover)
        in div (created by Animate)
        in div (created by IsolatedEventContainer)
        in IsolatedEventContainer (created by Animate)
        in Animate (created by Popover)
        in PopoverDetectOutside (created by WithFocusOutside(PopoverDetectOutside))
        in div (created by WithFocusOutside(PopoverDetectOutside))
        in WithFocusOutside(PopoverDetectOutside) (created by Popover)
        in Unknown (created by FocusReturn)
        in div (created by FocusReturn)
        in FocusReturn (created by Context.Consumer)
        in WithFocusReturn(Component) (created by WithConstrainedTabbing(WithFocusReturn(Component)))
        in div (created by WithConstrainedTabbing(WithFocusReturn(Component)))
        in WithConstrainedTabbing(WithFocusReturn(Component)) (created by Popover)"]

pento · 2019-09-06T04:58:24Z

Test: npm run test-e2e packages/e2e-tests/specs/reusable-blocks.test.js

Reusable Blocks › can be created

    expect(jest.fn()).not.toHaveErrored(expected)

    Expected mock function not to be called but it was called with:
    ["Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in %s.%s the componentWillUnmount method 
        in SlotComponent (created by Context.Consumer)
        in Slot (created by __experimentalBlockSettingsMenuPluginsExtensionSlot)
        in __experimentalBlockSettingsMenuPluginsExtensionSlot (created by Dropdown)
        in div (created by MenuGroup)
        in div (created by MenuGroup)
        in MenuGroup (created by WithInstanceId(MenuGroup))
        in WithInstanceId(MenuGroup) (created by Dropdown)
        in div (created by NavigableContainer)
        in NavigableContainer (created by ForwardRef(NavigableContainer))
        in ForwardRef(NavigableContainer) (created by ForwardRef(NavigableMenu))
        in ForwardRef(NavigableMenu) (created by Dropdown)
        in div (created by Animate)
        in div (created by IsolatedEventContainer)
        in IsolatedEventContainer (created by Animate)
        in Animate (created by Popover)
        in PopoverDetectOutside (created by WithFocusOutside(PopoverDetectOutside))
        in div (created by WithFocusOutside(PopoverDetectOutside))
        in WithFocusOutside(PopoverDetectOutside) (created by Popover)
        in Unknown (created by FocusReturn)
        in div (created by FocusReturn)
        in FocusReturn (created by Context.Consumer)
        in WithFocusReturn(Component) (created by WithConstrainedTabbing(WithFocusReturn(Component)))
        in div (created by WithConstrainedTabbing(WithFocusReturn(Component)))
        in WithConstrainedTabbing(WithFocusReturn(Component)) (created by Popover)
        in FillComponent (created by Context.Consumer)
        in Fill (created by Context.Consumer)
        in span (created by Context.Consumer)
        in Popover (created by Dropdown)
        in div (created by Dropdown)
        in Dropdown (created by DropdownMenu)
        in DropdownMenu (created by BlockActions)
        in div (created by ToolbarContainer)
        in ToolbarContainer (created by Toolbar)
        in Toolbar (created by BlockActions)
        in BlockActions (created by WithDispatch(BlockActions))
        in WithDispatch(BlockActions)
        in Unknown (created by WithSelect(WithDispatch(BlockActions)))
        in WithSelect(WithDispatch(BlockActions)) (created by BlockSettingsMenu)
        in BlockSettingsMenu (created by BlockToolbar)
        in div (created by BlockToolbar)
        in BlockToolbar
        in Unknown (created by WithSelect(BlockToolbar))
        in WithSelect(BlockToolbar) (created by BlockContextualToolbar)
        in div (created by NavigableContainer)
        in NavigableContainer (created by ForwardRef(NavigableContainer))
        in ForwardRef(NavigableContainer) (created by ForwardRef(NavigableMenu))
        in ForwardRef(NavigableMenu) (created by NavigableToolbar)
        in NavigableToolbar (created by BlockContextualToolbar)
        in BlockContextualToolbar (created by BlockListBlock)
        in div (created by BlockListBlock)
        in div (created by ForwardRef)
        in ForwardRef (created by IgnoreNestedEvents)
        in IgnoreNestedEvents (created by ForwardRef(IgnoreNestedEvents))
        in ForwardRef(IgnoreNestedEvents) (created by BlockListBlock)
        in BlockListBlock
        in Unknown
        in Unknown (created by (BlockListBlock))
        in (BlockListBlock) (created by WithFilters(BlockListBlock))
        in WithFilters(BlockListBlock) (created by IfCondition(WithFilters(BlockListBlock)))
        in IfCondition(WithFilters(BlockListBlock)) (created by WithDispatch(IfCondition(WithFilters(BlockListBlock))))
        in WithDispatch(IfCondition(WithFilters(BlockListBlock)))
        in Unknown (created by WithSelect(WithDispatch(IfCondition(WithFilters(BlockListBlock)))))
        in WithSelect(WithDispatch(IfCondition(WithFilters(BlockListBlock))))
        in Unknown (created by Pure(WithViewportMatch(WithSelect(WithDispatch(IfCondition(WithFilters(BlockListBlock)))))))
        in Pure(WithViewportMatch(WithSelect(WithDispatch(IfCondition(WithFilters(BlockListBlock)))))) (created by BlockList)
        in BlockAsyncModeProvider (created by BlockList)"]

pento · 2019-09-06T05:08:13Z

(I don't know if the SlotComponent errors are all the same thing, or different things with similar symptoms, so posting them all.)

Test: npm run test-e2e packages/e2e-tests/specs/table.test.js

Table › allows header and footer rows to be switched on and off

    expect(jest.fn()).not.toHaveErrored(expected)

    Expected mock function not to be called but it was called with:
    ["Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in %s.%s the componentWillUnmount method 
        in SlotComponent (created by Context.Consumer)
        in Slot (created by FormatToolbar)
        in div (created by ToolbarContainer)
        in ToolbarContainer (created by Toolbar)
        in Toolbar (created by FormatToolbar)
        in div (created by FormatToolbar)
        in FormatToolbar (created by RichText)
        in FillComponent (created by Context.Consumer)
        in Fill (created by BlockFormatControlsFill)
        in BlockFormatControlsFill (created by Context.Consumer)
        in IfBlockEditSelected(BlockFormatControlsFill) (created by RichText)"]

pento · 2019-09-06T05:19:19Z

Test: npm run test-e2e packages/e2e-tests/specs/plugins/meta-attribute-block.test.js

Block with a meta attribute › Should persist the meta attribute properly

    expect(jest.fn()).not.toHaveErrored(expected)

    Expected mock function not to be called but it was called with:
    ["Warning: A component is changing an uncontrolled input of type %s to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components%s undefined 
        in input (created by edit)
        in edit (created by Edit)
        in Edit (created by WithToolbarControls(Edit))
        in WithToolbarControls(Edit) (created by WithInspectorControl(WithToolbarControls(Edit)))
        in WithInspectorControl(WithToolbarControls(Edit)) (created by WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit))))
        in WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit)))
        in Unknown (created by WithDispatch(Component))
        in WithDispatch(Component)
        in Unknown (created by WithMultipleValidation(WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit)))))
        in WithMultipleValidation(WithInspectorControl(WithInspectorControl(WithToolbarControls(Edit)))) (created by WithFilters(Edit))
        in WithFilters(Edit) (created by BlockEdit)
        in BlockEdit (created by BlockListBlock)
        in BlockCrashBoundary (created by BlockListBlock)
        in div (created by IgnoreNestedEvents)
        in IgnoreNestedEvents (created by ForwardRef(IgnoreNestedEvents))
        in ForwardRef(IgnoreNestedEvents) (created by BlockListBlock)
        in div (created by BlockListBlock)
        in div (created by ForwardRef)
        in ForwardRef (created by IgnoreNestedEvents)
        in IgnoreNestedEvents (created by ForwardRef(IgnoreNestedEvents))
        in ForwardRef(IgnoreNestedEvents) (created by BlockListBlock)
        in BlockListBlock
        in Unknown
        in Unknown (created by (BlockListBlock))
        in (BlockListBlock) (created by WithFilters(BlockListBlock))
        in WithFilters(BlockListBlock) (created by IfCondition(WithFilters(BlockListBlock)))
        in IfCondition(WithFilters(BlockListBlock)) (created by WithDispatch(IfCondition(WithFilters(BlockListBlock))))
        in WithDispatch(IfCondition(WithFilters(BlockListBlock)))
        in Unknown (created by WithSelect(WithDispatch(IfCondition(WithFilters(BlockListBlock)))))
        in WithSelect(WithDispatch(IfCondition(WithFilters(BlockListBlock))))
        in Unknown (created by Pure(WithViewportMatch(WithSelect(WithDispatch(IfCondition(WithFilters(BlockListBlock)))))))
        in Pure(WithViewportMatch(WithSelect(WithDispatch(IfCondition(WithFilters(BlockListBlock)))))) (created by BlockList)
        in BlockAsyncModeProvider (created by BlockList)
        in div (created by BlockList)
        in BlockList (created by WithDispatch(BlockList))
        in WithDispatch(BlockList)
        in Unknown (created by WithSelect(WithDispatch(BlockList)))
        in WithSelect(WithDispatch(BlockList))
        in Unknown (created by VisualEditor)
        in div (created by CopyHandler)
        in CopyHandler (created by WithDispatch(CopyHandler))
        in WithDispatch(CopyHandler) (created by VisualEditor)
        in div (created by ObserveTyping)
        in ObserveTyping (created by WithSafeTimeout(ObserveTyping))
        in WithSafeTimeout(ObserveTyping) (created by WithDispatch(WithSafeTimeout(ObserveTyping)))
        in WithDispatch(WithSafeTimeout(ObserveTyping))
        in Unknown (created by WithSelect(WithDispatch(WithSafeTimeout(ObserveTyping))))
        in WithSelect(WithDispatch(WithSafeTimeout(ObserveTyping))) (created by VisualEditor)
        in div (created by WritingFlow)
        in div (created by WritingFlow)
        in WritingFlow (created by WithDispatch(WritingFlow))
        in WithDispatch(WritingFlow)
        in Unknown (created by WithSelect(WithDispatch(WritingFlow)))
        in WithSelect(WithDispatch(WritingFlow)) (created by VisualEditor)
        in div (created by Typewriter)
        in Typewriter
        in Unknown (created by WithSelect(Typewriter))
        in WithSelect(Typewriter) (created by VisualEditor)
        in div (created by BlockSelectionClearer)
        in BlockSelectionClearer (created by WithDispatch(BlockSelectionClearer))
        in WithDispatch(BlockSelectionClearer)
        in Unknown (created by WithSelect(WithDispatch(BlockSelectionClearer)))
        in WithSelect(WithDispatch(BlockSelectionClearer)) (created by VisualEditor)
        in VisualEditor (created by Layout)
        in div (created by Layout)
        in div (created by FocusReturnProvider)
        in FocusReturnProvider (created by Layout)
        in Layout
        in Unknown (created by WithViewportMatch(Layout))
        in WithViewportMatch(Layout) (created by NavigateRegions(WithViewportMatch(Layout)))
        in div (created by NavigateRegions(WithViewportMatch(Layout)))
        in NavigateRegions(WithViewportMatch(Layout)) (created by WithDispatch(NavigateRegions(WithViewportMatch(Layout))))
        in WithDispatch(NavigateRegions(WithViewportMatch(Layout)))
        in Unknown (created by WithSelect(WithDispatch(NavigateRegions(WithViewportMatch(Layout)))))
        in WithSelect(WithDispatch(NavigateRegions(WithViewportMatch(Layout)))) (created by Editor)
        in ErrorBoundary (created by Editor)
        in BlockEditorProvider (created by WithDispatch(BlockEditorProvider))
        in WithDispatch(BlockEditorProvider)
        in Unknown (created by Context.Consumer)
        in WithRegistryProvider(WithDispatch(BlockEditorProvider)) (created by EditorProvider)
        in EditorProvider (created by WithDispatch(EditorProvider))
        in WithDispatch(EditorProvider)
        in Unknown (created by WithSelect(WithDispatch(EditorProvider)))
        in WithSelect(WithDispatch(EditorProvider))
        in Unknown (created by Context.Consumer)
        in WithRegistryProvider(WithSelect(WithDispatch(EditorProvider))) (created by Editor)
        in div (created by DropZoneProvider)
        in DropZoneProvider (created by Editor)
        in SlotFillProvider (created by Editor)
        in StrictMode (created by Editor)
        in Editor (created by WithDispatch(Editor))
        in WithDispatch(Editor)
        in Unknown (created by WithSelect(WithDispatch(Editor)))
        in WithSelect(WithDispatch(Editor))"]

pento · 2019-09-06T05:20:29Z

Test: npm run test-e2e packages/e2e-tests/specs/datepicker.test.js

Datepicker › should show the publishing date if the date is in the past

    expect(jest.fn()).not.toHaveErrored(expected)

    Expected mock function not to be called but it was called with:
    ["Warning: Unsafe lifecycle methods were found within a strict-mode tree:%s
    
    %s
    
    Learn more about this warning here:
    https://fb.me/react-strict-mode-warnings 
        in StrictMode (created by Editor)
        in Editor (created by WithDispatch(Editor))
        in WithDispatch(Editor)
        in Unknown (created by WithSelect(WithDispatch(Editor)))
        in WithSelect(WithDispatch(Editor)) componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: CalendarMonth, CalendarMonthGrid, DayPicker, DayPickerSingleDateController, OutsideClickHandler
    
    componentWillUpdate: Please update the following components to use componentDidUpdate instead: DayPicker, DayPickerSingleDateController"],["Warning: Legacy context API has been detected within a strict-mode tree: %s
    
    Please update the following components: %s
    
    Learn more about this warning here:
    https://fb.me/react-strict-mode-warnings 
        in StrictMode (created by Editor)
        in Editor (created by WithDispatch(Editor))
        in WithDispatch(Editor)
        in Unknown (created by WithSelect(WithDispatch(Editor)))
        in WithSelect(WithDispatch(Editor)) withStyles(CalendarDay), withStyles(CalendarMonth), withStyles(CalendarMonthGrid), withStyles(DayPicker), withStyles(DayPickerNavigation)"]

thomasplevy · 2019-10-22T19:13:27Z

@pento

I'm seeing these (or possibly related) errors when using a RichText component inside the edit() method of a custom block.

It looks like the errors are coming from the Toolbar components on the RichText control, but I'm not positive.

I've been trying to figure out if I'm doing something wrong (ie trying to mount the components on an unmounted component) but I'm really not a React expert (yet) and I don't know exactly what this means or how to debug it further.

Is this something that's actually coming from a core package or, if this is on me, do you have any advice or recommendations for me on either where to look to learn more about how to do this properly?

Thanks!

Full error (in case it helps):

react-dom.js?ver=16.9.0:539 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in SlotComponent (created by Context.Consumer)
    in Slot (created by FormatToolbar)
    in div (created by ToolbarContainer)
    in ToolbarContainer (created by Toolbar)
    in Toolbar (created by FormatToolbar)
    in div (created by FormatToolbar)
    in FormatToolbar (created by RichText)
    in fill_FillComponent (created by Context.Consumer)
    in Fill (created by BlockFormatControlsFill)
    in BlockFormatControlsFill (created by Context.Consumer)
    in IfBlockEditSelected(BlockFormatControlsFill) (created by RichText)

youknowriad · 2019-10-23T16:24:26Z

@gziolo Is this still the case, I think you worked on related things lately?

gziolo · 2019-10-24T10:45:10Z

I was working on different issues lately. This is still valid and it's blocking #14845 - use SCRIPT_DEBUG in end-to-end test environment.

gziolo · 2019-10-24T10:46:58Z

@talldan are you still working on it?

talldan · 2020-02-05T04:56:34Z

@gziolo Sorry, missed the ping. I think I lost track that I was supposed to be working on this. Sorry!

talldan · 2020-02-05T04:57:45Z

#19642 looks like another one related to Slot, might be the same issue.

gziolo · 2020-02-05T07:03:44Z

#19642 looks like another one related to Slot, might be the same issue.

@diegohaz is working on a new implementation for SlotFill in #19242, maybe it will fix this issue?

diegohaz · 2020-02-06T08:34:58Z

I'm still seeing those Can't perform a React state update warnings when applying the refactored SlotFill module to BlockControls. Other parts are still using the old implementation though (also because the new SlotFill implementation only supports the current <Slot bubblesVirtually /> scenario, which uses React Portal). I guess that, even if it fixes the warning, we would only get rid of it completely when all the other slots are updated.

By the way, #19242 (slot fill refactor) is kind of done and is blocking other tasks (#20008). I would appreciate any review there! 😆

noahtallen · 2020-05-08T18:07:56Z

BTW, the slot fill issue still exists:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in SlotComponent (created by Context.Consumer)
    in Slot (created by Slot)
    in Slot (created by FormatToolbar)
    in div (created by ToolbarGroupContainer)
    in ToolbarGroupContainer (created by ToolbarGroup)
    in ToolbarGroup (created by FormatToolbar)
    in div (created by FormatToolbar)
    in FormatToolbar (created by FormatToolbarContainer)
    in Fill (created by Fill)
    in Fill (created by BlockFormatControlsFill)
    in BlockFormatControlsFill (created by BlockFormatControlsFill)
    in BlockFormatControlsFill (created by Context.Consumer)
    in IfBlockEditSelected(BlockFormatControlsFill) (created by FormatToolbarContainer)
    in FormatToolbarContainer (created by RichText)

noahtallen · 2020-05-08T18:08:53Z

I'm also seeing another state update on master:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
    in ForwardRef(ToolbarContainer) (created by ForwardRef(Toolbar))
    in ForwardRef(Toolbar) (created by NavigableToolbar)
    in NavigableToolbar (created by BlockContextualToolbar)
    in div (created by BlockContextualToolbar)
    in BlockContextualToolbar (created by BlockPopover)
    in div (created by Animate)
    in div (created by ForwardRef)
    in ForwardRef (created by Animate)
    in Animate (created by Popover)
    in PopoverDetectOutside (created by WithFocusOutside(PopoverDetectOutside))
    in div (created by WithFocusOutside(PopoverDetectOutside))
    in WithFocusOutside(PopoverDetectOutside) (created by Popover)
    in Fill (created by Fill)
    in Fill (created by Popover)

You can trigger it by going to post-new.php and clicking between the title and the main editor several times

noahtallen · 2020-05-08T18:10:15Z

I wonder if it happens here? It seems to fit the stack trace:

gutenberg/packages/components/src/toolbar/toolbar-container.js

Line 20 in 70a4af6

const toolbarState = useToolbarState( { loop: true, baseId: props.id } );

diegohaz · 2020-05-08T18:15:45Z

@noahtallen Does this happen before #20008?

noahtallen · 2020-05-08T18:38:06Z

No, I checked out the commit previous to that merge and it does not happen before that PR. I used the same post/post content to test as well. repro steps:

Create a post with a title and a paragraph and save it.
Select the paragraph (so that you could type into it)
Select the ~~header~~ I mean title (so that you could type into it)
Observe the react warning in the console

before that PR, step 4 doesn't happen. no warning displays

diegohaz · 2020-05-08T18:42:45Z

Thanks! :)
I'll take a look into that.

noahtallen · 2020-05-08T18:58:28Z

thanks for noticing!

diegohaz · 2020-05-18T04:09:46Z

Created a simple reproduction here: https://codesandbox.io/s/wordpress-slotfill-memory-leak-warning-nmcmc?file=/src/App.js

It doesn't seem to happen when Slot has bubblesVirtually prop.

It also doesn't happen when we memoize the Fill children (or if it's a primitive value like a string). So my current guess is that it's related to these lines:

gutenberg/packages/components/src/slot-fill/fill.js

Lines 35 to 40 in d15a208

    
           useLayoutEffect( () => { 
        
           	ref.current.children = children; 
        
           	if ( slot ) { 
        
           		slot.forceUpdate(); 
        
           	} 
        
           }, [ children ] );

React elements (<div>test</div>) will be always different on every render.

talldan · 2021-07-05T03:26:24Z

#33171 reported a React warning (Can't perform a React state update on an unmounted component.) when replacing images in the gallery block. #25305 may help, as I believe the problem is with the GalleryImage component.

Mamaduka · 2024-07-31T15:06:25Z

I'm going to close this issue.

Why?

StrictMode checks are development only, and the project runs the e2e tests in production mode.
React no longer warns for Can't perform a React state update on an unmounted component.
Remaining strict mode warnings logged by e2e tests where fixed in Try: Re-enable React StrictMode #61943.
Any new reports will be fixed separately.

pento added the [Type] Bug An existing feature does not function as intended label Sep 6, 2019

pento assigned talldan Sep 6, 2019

gziolo added [Priority] High Used to indicate top priority items that need quick attention [Type] Code Quality Issues or PRs that relate to code quality labels Sep 19, 2019

youknowriad removed the [Priority] High Used to indicate top priority items that need quick attention label Oct 23, 2019

gziolo mentioned this issue Oct 24, 2019

Testing: Use SCRIPT_DEBUG in end-to-end test environment #14845

Open

gziolo added the Needs Dev Ready for, and needs developer efforts label Oct 24, 2019

talldan removed their assignment Feb 5, 2020

talldan mentioned this issue Feb 5, 2020

Warning: Can't perform a React state update on an unmounted component when SCRIPT_DEBUG true #19642

Closed

aduth mentioned this issue Mar 2, 2020

Components: Refactor SlotFill #19242

Merged

6 tasks

aduth mentioned this issue Mar 31, 2020

Insert post title instead of URL, when adding a link to an existing post #21240

Merged

9 tasks

iandunn mentioned this issue May 7, 2020

FSE: Adding a post content block to a post causes a WSOD #22080

Closed

This was referenced May 8, 2020

FSE: Compute the block state of different entities separately #21368

Merged

Try switching wordpress install in travis to wp-env #22303

Closed

diegohaz mentioned this issue May 19, 2020

Potential React warning triggered by useToolbarState ariakit/ariakit#650

Closed

talldan mentioned this issue Jun 3, 2020

Nav block: enable creation from existing WP Menus #18869

Merged

12 tasks

This was referenced Jun 15, 2020

Removing Navigation Block causes console warning re: state #22830

Closed

Upgrade Reakit to version 1.1.0 #23236

Merged

youknowriad mentioned this issue Jun 22, 2020

Fix React warning while unmounting slots #23365

Merged

mikejolley mentioned this issue Apr 9, 2021

Fix useForceUpdate Memory Leak: Only setState if the component is still mounted #30667

Merged

2 tasks

talldan mentioned this issue Jul 5, 2021

JavaScript error when replacing image in Gallery Widget #33171

Closed

Mamaduka mentioned this issue Feb 2, 2023

Enable React StrictMode again #47639

Merged

Mamaduka closed this as completed Jul 31, 2024

Mamaduka removed the Needs Dev Ready for, and needs developer efforts label Jul 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing up StrictMode errors in the e2e tests. #17355

Fixing up StrictMode errors in the e2e tests. #17355

pento commented Sep 6, 2019 •

edited by gziolo

Loading

pento commented Sep 6, 2019 •

edited

Loading

pento commented Sep 6, 2019

pento commented Sep 6, 2019

pento commented Sep 6, 2019

pento commented Sep 6, 2019

thomasplevy commented Oct 22, 2019

youknowriad commented Oct 23, 2019

gziolo commented Oct 24, 2019

gziolo commented Oct 24, 2019

talldan commented Feb 5, 2020

talldan commented Feb 5, 2020

gziolo commented Feb 5, 2020

diegohaz commented Feb 6, 2020

noahtallen commented May 8, 2020

noahtallen commented May 8, 2020

noahtallen commented May 8, 2020 •

edited

Loading

diegohaz commented May 8, 2020

noahtallen commented May 8, 2020 •

edited

Loading

diegohaz commented May 8, 2020

noahtallen commented May 8, 2020

diegohaz commented May 18, 2020 •

edited

Loading

talldan commented Jul 5, 2021

Mamaduka commented Jul 31, 2024

Fixing up StrictMode errors in the e2e tests. #17355

Fixing up StrictMode errors in the e2e tests. #17355

Comments

pento commented Sep 6, 2019 • edited by gziolo Loading

pento commented Sep 6, 2019 • edited Loading

pento commented Sep 6, 2019

pento commented Sep 6, 2019

pento commented Sep 6, 2019

pento commented Sep 6, 2019

thomasplevy commented Oct 22, 2019

youknowriad commented Oct 23, 2019

gziolo commented Oct 24, 2019

gziolo commented Oct 24, 2019

talldan commented Feb 5, 2020

talldan commented Feb 5, 2020

gziolo commented Feb 5, 2020

diegohaz commented Feb 6, 2020

noahtallen commented May 8, 2020

noahtallen commented May 8, 2020

noahtallen commented May 8, 2020 • edited Loading

diegohaz commented May 8, 2020

noahtallen commented May 8, 2020 • edited Loading

diegohaz commented May 8, 2020

noahtallen commented May 8, 2020

diegohaz commented May 18, 2020 • edited Loading

talldan commented Jul 5, 2021

Mamaduka commented Jul 31, 2024

Why?

pento commented Sep 6, 2019 •

edited by gziolo

Loading

pento commented Sep 6, 2019 •

edited

Loading

noahtallen commented May 8, 2020 •

edited

Loading

noahtallen commented May 8, 2020 •

edited

Loading

diegohaz commented May 18, 2020 •

edited

Loading