Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockquote and pullquote blocks should be one block? #17562

Closed
hugobaeta opened this issue Sep 24, 2019 · 1 comment
Closed

blockquote and pullquote blocks should be one block? #17562

hugobaeta opened this issue Sep 24, 2019 · 1 comment

Comments

@hugobaeta
Copy link

There are two blocks allowing you to insert blockquotes in the post, one called blockquote and the other pullquote. They output slightly different markup.

I don't understand the redundancy here: why two blocks that do, semantically, the same thing? Shouldn't this be block styles/options territory?

One uses a <blockquote> at the root level, the other is the same but with a <figure> wrapper. Wouldn't it be more consistent and flexible to use the <figure> wrapper on both blocks?

Better yet, why not make them just one block and provide a block option variation like other blocks do?

Let's discuss!

Screen Shot 2019-09-24 at 2 53 44 PM

Desktop (please complete the following information):

  • OS: MacOS Mojave (10.14.6)
  • Browser: Chrome
  • Version: 77

Additional context

  • Gutenberg bundled with core in 5.2.3.
@youknowriad
Copy link
Contributor

This is a duplicate of #11610 there's some discussion there to explain the reasoning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants