Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: tab navigation changed since WordPress 5.2 #17847

Closed
jeherve opened this issue Oct 8, 2019 · 5 comments · Fixed by #18624
Closed

Accessibility: tab navigation changed since WordPress 5.2 #17847

jeherve opened this issue Oct 8, 2019 · 5 comments · Fixed by #18624
Assignees
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Status] In Progress Tracking issues with work in progress

Comments

@jeherve
Copy link
Contributor

jeherve commented Oct 8, 2019

When using WordPress' current stable release, you can rely on the Tab key to quickly start composing:

  1. Focus is set to the title as you open the editor.
  2. Once you've added a title, you can hit Tab to quickly get to the main content area, where you'll be able to add blocks (by hitting / for example).

This changed with the current version of Gutenberg.

Steps to reproduce the behavior:

  1. Go to Posts > Add New
  2. Enter a post title
  3. Hit Tab.
  4. Start typing. It turns out you are not in the main content area.

Desktop (please complete the following information):

  • OS: macOS Catalina
  • Browser: Chrome
  • Version: 77.0.3865.90
@brentswisher brentswisher added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release labels Oct 8, 2019
@brentswisher
Copy link
Contributor

Tested and verified. It appears to be a side effect of #16500 similar to #17776.

@youknowriad - any thoughts on this? If I disable navigation mode in WritingFlow it prevents this, but I am not sure where/how that should be implemented. I could pull isCleanNewPost from core/editor, but I'm thinking I shouldn't do that in this package?

Code that fixes the issue using isCleanNewPost as proof of concept here: 5cdc3d2

@brentswisher brentswisher added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Oct 14, 2019
@brentswisher brentswisher self-assigned this Oct 14, 2019
@youknowriad
Copy link
Contributor

This was intentional, the idea is that by default you're in "Navigation Mode" to ease cross-block navigation for screen reader and keyboard users.

You can hit "Enter" to enter "edit mode".

We're considering explicit separation between these two modes here #17088 and potentially changing the default mode.

@youknowriad youknowriad removed the [Type] Regression Related to a regression in the latest release label Oct 15, 2019
@brentswisher
Copy link
Contributor

@youknowriad I think #17088 could help alleviate this, but I would question whether starting a new post in navigation mode eases navigation specifically on a new post. If you compare the two processes:

"Old" Process:

  1. Click add New Post
  2. Title is auto-focused
  3. Add a title, hit tab
  4. The cursor is inserted into the first paragraph and you can begin composing

Screenshot:
H6P7JZ9X53

"New" Process:

  1. Click add New Post
  2. Title is auto-focused
  3. Add a title, hit tab
  4. The cursor is moved to the first paragraph in navigation mode
  5. If I start typing text, nothing happens. There is no indication of why what I am typing is not on the screen or what to do to make that happen.
  6. If I hit enter, I am dropped into "edit" mode and can enter text (But it is not clear that this is what I need to do)

Screenshot:
spyQx38ret

The fact that as I type when I first tab to the paragraph there is no indication to me what is happening seems problematic. With no other content to actually navigate to, I'm questioning the logic of starting in navigation mode? Maybe it would be better to only default it to navigation when editing an existing post?

@youknowriad
Copy link
Contributor

I agree, it's not perfect, and yeah, this mode have been in the plugin for just a month or two so we can iterate on it and adapt it. I wouldn't mind a PR to switch the default (and check with a11y)

@brentswisher brentswisher added the Needs Accessibility Feedback Need input from accessibility label Oct 23, 2019
@gziolo
Copy link
Member

gziolo commented Nov 12, 2019

Should we raise for the next accessibility weekly meeting? It would be great to decide whether it’s fine as is or this should be offered as an option activated upon using esc key. I personally find it confusing in some cases as it isn’t predictable when mixing the mouse/trackpad and keyboard usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants