Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview: Block-based Demo Theme #19143

Closed
9 tasks
epiqueras opened this issue Dec 13, 2019 · 3 comments
Closed
9 tasks

Overview: Block-based Demo Theme #19143

epiqueras opened this issue Dec 13, 2019 · 3 comments
Assignees
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues
Milestone

Comments

@epiqueras
Copy link
Contributor

Since #18554, we've had a way of shipping demo block templates for the full site editing experiment in the Gutenberg plugin. It'd be nice if we shipped a block-based version of TwentyTwenty in there, that we could then package into a standalone theme as an example implementation for block based themes. It will also be very nice to work with in the new site editor.

Let's keep track of needed work here:

  • Index/archive template. (PR)
    • They are shared so I guess the archive block will just not output anything if get_the_archive_title is not set.
    • Header template part. (PR)
      • Site description block. (PR)
    • Archive block. (PR)
      • Should wrap posts block.
    • Posts block with pagination. (PR)
      • Receives context from query or parent block, e.g. archive block.
    • Footer template part with widget replacements. (PR)
  • Singular template. (PR)
    • Comments block. (PR)
  • 404 template. (PR)
@epiqueras epiqueras added [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing labels Dec 13, 2019
@epiqueras epiqueras added this to the Future milestone Dec 13, 2019
@epiqueras epiqueras self-assigned this Dec 13, 2019
@dashkevych
Copy link

Are we allowed to add custom CSS classes to the blocks in these templates (for example, if the theme has decided to use utility-first CSS framework) ?

If we are allowed to use custom CSS classes in the templates, how the template updates will work if the template will be saved as CPT after the user's changes (https://youtu.be/__VN9VNtT0E).

@epiqueras
Copy link
Contributor Author

Yes, the classes will also save in the created CPT post.

These templates are just the editor's serialized output. You could also use block style variations.

@mtias
Copy link
Member

mtias commented Mar 2, 2021

We are no longer bundling a demo theme.

@mtias mtias closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues
Projects
None yet
Development

No branches or pull requests

3 participants