Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment of dates in DatePicker is confusing #19228

Closed
jeremyfelt opened this issue Dec 19, 2019 · 2 comments
Closed

Alignment of dates in DatePicker is confusing #19228

jeremyfelt opened this issue Dec 19, 2019 · 2 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@jeremyfelt
Copy link
Member

Describe the bug
On WordPress 5.3.2 with Gutenberg 7.1.0, the day numbers in the date picker are not aligned with the day names in their respective columns when using the date picker to schedule a post's publish date.

When selecting the day number, I had to pay closer attention than I expected when deciding which date was Friday.

It appears that this is intentional as part of #18856, which fixed #17129.

To reproduce
Steps to reproduce the behavior:

  1. Add a new post.
  2. Click "Immediately" next to "Publish" to show the date picker interface.

Expected behavior
I expect the numbers on the calendar to be aligned with their respective day text.

Screenshots
Before: (WordPress 5.3.2, no Gutenberg plugin)
Screen Shot 2019-12-18 at 4 16 31 PM

After: (WordPress 5.3.2, Gutenberg plugin 7.1.0)
Screen Shot 2019-12-18 at 4 16 52 PM

Desktop (please complete the following information):

  • OS: MacOS Mojave
  • Browser Firefox
  • Version 71
@talldan talldan added [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Dec 19, 2019
@talldan
Copy link
Contributor

talldan commented Dec 19, 2019

Thanks for pointing this out @jeremyfelt, seems like there are all of a sudden lots of issues with the date picker!

@abdel-h abdel-h mentioned this issue Dec 22, 2019
Merged
6 tasks
@tellthemachines
Copy link
Contributor

Closing as this was fixed in #19294.

@tellthemachines tellthemachines mentioned this issue Jan 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeremyfelt @talldan @tellthemachines