Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons block: aligning broken #19616

Closed
ellatrix opened this issue Jan 14, 2020 · 3 comments · Fixed by #19824
Closed

Buttons block: aligning broken #19616

ellatrix opened this issue Jan 14, 2020 · 3 comments · Fixed by #19824
Assignees
Labels
[Block] Buttons Affects the Buttons Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@ellatrix
Copy link
Member

None of the alignment buttons of the buttons block work.

@aduth aduth added [Block] Buttons [Type] Bug An existing feature does not function as intended labels Jan 14, 2020
@ellatrix ellatrix added the [Type] Regression Related to a regression in the latest release label Jan 14, 2020
@youknowriad youknowriad added [Block] Buttons Affects the Buttons Block and removed [Block] Buttons labels Jan 16, 2020
@tijosh
Copy link

tijosh commented Jan 22, 2020

The alignment works, but you have to select the parent Buttons block rather than the Button itself:

Screenshot

Then, you can select the desired alignment:

Screenshot

Screenshot

Less than ideal—it would be good if choosing the individual button's alignment also set the parent container's alignment.

@ellatrix
Copy link
Member Author

Sounds like the individual buttons should not have any alignment buttons then.

@strarsis
Copy link
Contributor

Well, the buttons block contains button blocks, hence it acts as a container of button blocks.
What if a designer makes a more fancy buttons block, e.g. one that aligns all its button blocks into a ring? What if some of these button blocks should be aligned to the right and some to the center, etc.?
Just removing the individual alignment options from a single button block inside a buttons block would also take some possibilities away from the theme designer. What about just hiding that option or making it possible to be enabled by the theme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants