Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Library: FSE Blocks: Use block context #21665

Closed
12 tasks done
aduth opened this issue Apr 16, 2020 · 2 comments · Fixed by #21696
Closed
12 tasks done

Block Library: FSE Blocks: Use block context #21665

aduth opened this issue Apr 16, 2020 · 2 comments · Fixed by #21696
Labels
[Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@aduth
Copy link
Member

aduth commented Apr 16, 2020

Previously: #21467
Related: #21662

Context:

#21467 implements support for formal block context. This should be used in the implementation of full-site editing blocks, many of which currently either render static content, or retrieve the post context by other means (see #21662). These should be updated to retrieve entities for their respective context, using block context.

Progress:

@aduth
Copy link
Member Author

aduth commented May 19, 2020

Reopening since #21696 only updated the server-side implementation.

Client-side will still require revisions, largely to reimplement the existing blocks to avoid using useEntityProp in most cases in favor of a combination of (a) block context and (b) core-data entities.

An example reference is #22359, updating the Post Author block to use block context in the client-side implementation.

@aduth aduth removed their assignment May 25, 2020
@ntsekouras
Copy link
Contributor

Closing as all of the tasks have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants