Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text after gallery is really close to gallery #2188

Closed
karmatosed opened this issue Aug 3, 2017 · 2 comments
Closed

Text after gallery is really close to gallery #2188

karmatosed opened this issue Aug 3, 2017 · 2 comments
Assignees
@karmatosed
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@karmatosed
Copy link
Member

This was reported by @helen:

Why is the text right up under the gallery in the preview but not in the editor? Adding an extra line (entire block) doesn't fix it :(

I can replicate this using Twenty Seventeen:

2017-08-03 at 14 46

Whilst technically a front end theme issue, it would be good to at least avoid this on every theme - it's going to be common.
@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Aug 3, 2017
@mtias
Copy link
Member

mtias commented Aug 3, 2017

This is just a matter of providing default margins for gallery, should be a simple change if you want to go for it.

@mtias mtias added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Aug 3, 2017
@karmatosed karmatosed self-assigned this Aug 3, 2017
@mtias
Copy link
Member

mtias commented Aug 18, 2017

This was done in #2291

@mtias mtias closed this as completed Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karmatosed karmatosed

Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karmatosed @mtias