Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Allow Spacer Block #24028

Closed
shaunandrews opened this issue Jul 17, 2020 · 3 comments · Fixed by #29133
Closed

Navigation: Allow Spacer Block #24028

shaunandrews opened this issue Jul 17, 2020 · 3 comments · Fixed by #29133
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress

Comments

@shaunandrews
Copy link
Contributor

Allowing the Spacer block as an inner block of Navigation would let people create visual groupings of links. Something like this:

image

A horizontal option for the Spacer block could be useful in horizontal navigations, too:

image

@shaunandrews shaunandrews added the [Block] Navigation Affects the Navigation Block label Jul 17, 2020
@draganescu
Copy link
Contributor

This issue is currently blocked by the following aspects:

  • currently the spacer block only handles vertical spacing
  • adding horizontal spacing to the spacer block raises issues with fixed horizontal element sizes and responsiveness

There are also the related issues #23293 and #23294 which could eventually solve this better.

@noisysocks
Copy link
Member

I think let's drop this for WP 5.6.

@draganescu
Copy link
Contributor

I would love to have the spacer included in the list of supported blocks in building complex navigation, but it is not a requirement for the editor so I will remove this from the Navigation project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants