Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify help or description text styling #25851

Closed
karmatosed opened this issue Oct 6, 2020 · 2 comments
Closed

Unify help or description text styling #25851

karmatosed opened this issue Oct 6, 2020 · 2 comments
Assignees
Labels
Needs Design Feedback Needs general design feedback.

Comments

@karmatosed
Copy link
Member

karmatosed commented Oct 6, 2020

This is a small pickup and I am going to spin up a PR to go with this issue. Currently, there are a few variations in our help text. Some have italics, some don't. The default style has italics. What this small PR looks to start is unify where we have help styling and try and bring in one style.

Classes impacted.

The following is a list of classes impacted:

.components-base-control__help .components-form-token-field__help

In action

The following images show the idea of what trying to work towards in unifying the styling. Currently these don't have the same styling. Here are before:

image

image

Here hopefully with unification:
image

image

Feedback

I am looking for feedback around this styling. Looping in @jasmussen here and giving big props for the nudge to clean this up along with work being done in options iterations.

@jasmussen
Copy link
Contributor

This looks like a nice win.

@karmatosed
Copy link
Member Author

Looks like this didn't close with the PR so closing as this is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

2 participants