Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verse block: Missing typography controls #28099

Closed
paaljoachim opened this issue Jan 11, 2021 · 2 comments
Closed

Verse block: Missing typography controls #28099

paaljoachim opened this issue Jan 11, 2021 · 2 comments
Labels
[Block] Verse Affects the Verse block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

We are adding typography and color controls to the text blocks that still do not have these features.

This issue is focused on the Verse block that still needs typography controls.

Screen Shot 2021-01-11 at 13 51 35

Associated issue:
Consider adding color and text size customizations to all text-based blocks.
#8171
@paaljoachim paaljoachim added [Block] Verse Affects the Verse block [Type] Enhancement A suggestion for improvement. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Dev Ready for, and needs developer efforts Good First Issue An issue that's suitable for someone looking to contribute for the first time and removed First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Jan 11, 2021
@juanfra
Copy link
Member

juanfra commented Jan 20, 2021

Hi @paaljoachim,

I've been checking this one and apparently it was fixed here: #27735

Do you feel we should close this one?

Best,
Juan.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Jan 20, 2021 •
edited
Loading

Hey @juanfra Juan

Thank you for your discovery!

Screen Shot 2021-01-20 at 16 18 08

We can now close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Verse Affects the Verse block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juanfra @paaljoachim