Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles: Add color-contrast checks #28782

Closed
aristath opened this issue Feb 5, 2021 · 2 comments
Closed

Global styles: Add color-contrast checks #28782

aristath opened this issue Feb 5, 2021 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json

Comments

@aristath
Copy link
Member

aristath commented Feb 5, 2021

Came up during a contributors day, from users testing FSE for the 1st time.

When editing a post, selecting white background with white text for a paragraph brings up a notice about the color-a11y.
We should have the same behavior while in global-styles, both for the per-block-type options and for the global options.

cc @moorscode

@aristath aristath added [a11y] Color Contrast Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Feb 5, 2021
@aristath
Copy link
Member Author

aristath commented Mar 4, 2021

Closing this one in favor of #29457

@oandregal
Copy link
Member

There are two things here:

  • One is the contrast checker for the block sidebar => the issue seems to be that the editor canvas is iframed, but the contrast checker feature is expected to work normally. I think we can leave Site editor: show color warning if poor contrast colors are picked #29457 for this, as there's move momentum there.

  • The other is the global sidebar => this is different in that we are not targeting a specific block, so we don't have blocks to check the contrast on but we have styles that affect the whole site. We'd need to check the whole document in this case. The advantage here is that we have access to structure data for colors, so perhaps we can do some things. Unsure this is worth it, though.

@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Color Contrast labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Development

No branches or pull requests

3 participants