Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Block: allow for the ability to undo setting changes #29494

Closed
annezazu opened this issue Mar 3, 2021 · 2 comments · Fixed by #30203
Closed

Query Block: allow for the ability to undo setting changes #29494

annezazu opened this issue Mar 3, 2021 · 2 comments · Fixed by #30203
Assignees
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] History History, undo, redo, revisions, autosave. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Mar 3, 2021

Description

As part of the second FSE call for testing, a person who responded with feedback found that they were unable to undo changes to the settings when using the Query block after initially selecting how the block should display.

Step-by-step reproduction instructions

  1. Use a block based theme and the latest version of Gutenberg to setup the FSE experience.
  2. Go to "Site Editor (beta)"
  3. Add a query block
  4. Select an initial setup (Post title with excerpt, etc)
  5. Try to undo the selection. Find out that you can't!

Expected behaviour

I expected to be able to undo setting changes.

Actual behaviour

I was unable to undo changes to the initial query block setup.

Screenshots or screen recording (optional)

query.undo.mov

WordPress information

  • WordPress version: 5.6.2
  • Gutenberg version: 10.0.2
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? TT1 Blocks
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] History History, undo, redo, revisions, autosave. [Block] Query Loop Affects the Query Loop Block labels Mar 3, 2021
@priethor priethor added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Mar 18, 2021
@ntsekouras ntsekouras self-assigned this Mar 24, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 24, 2021
@annezazu
Copy link
Contributor Author

annezazu commented May 6, 2021

@ntsekouras reopening this as the undo option seems to be slightly broken if you choose "Start Blank" but then want to go back to choose from the new pattern selector. Here's a video:

query.undo.with.patterns.mov

This is using 10.6 RC

@annezazu annezazu reopened this May 6, 2021
@ntsekouras
Copy link
Contributor

This not actually about Query because in this case we haven't yet created anything, so undo works properly. It's a combination of __experimentalBlockPatternSetup and __experimentalBlockVariationPicker to add conditionally a back button.

I've created an issue that describes the problem better here: #31593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] History History, undo, redo, revisions, autosave. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants