Verse block: Add support for the padding to the verse block #29820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Block] Verse
|
Size Change: +1.27 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Seems cool. What does the removal of the 1em default padding mean for existing themes? |
If existing themes add the padding to the frontend to match the editor and don't also add it to the editor styles then the frontend won't match the editor anymore - the frontend will stay the same though. |
|
I'm thinking mostly in terms of existing themes that don't style the verse, but perhaps relied on the existing verse style. Very edgecase stuff, and probably acceptable. |
Yeah this could be a problem, but it would only impact the editor. |
|
Is not adding the visualizer on purpose? 375 (directory) themes uses wp-block-verse but that doesn't tell us much |
jasmussen
approved these changes
Mar 12, 2021
|
@carolinan good point, I added the visualizer. |
|
For some reason, the visualizer goes outside the block 🤔 Perhaps it is better to remove it again.
block editor, Twenty Twenty-One. Chrome Version 89.0.4389.82, Win10 Other than that the PR works well for me. |
… within the block boundary
|
I added a wrapper div to fix this:
Not sure if there's a better way to do this. |
|
If at all possible, I would avoid a wrapper. In the past adding wrappers have bitten us. |
|
I have the same issue about the need for a wrapper in #29335 for the visualizer in the group block, I'm leaning towards removing the visualizer for now until we find a non intrusive way to do it. (potentially using a Popover but may be a bit complex) |
|
The visualizer is nice to have but the padding is still visible (more visible if it is large, of course). |
|
Ok, removed the visualizer! |
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for custom padding to the Verse block. This also removed padding from the block in the editor, so that the editor and the frontend match.
How has this been tested?
Screenshots
Editor:
Frontend:
Types of changes
New feature
Checklist: