Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable blocks and Template Parts isolated editing view: Add menu in top toolbar for navigating to usage locations #30622

Closed
critterverse opened this issue Apr 8, 2021 · 2 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.

Comments

@critterverse
Copy link
Contributor

Hi all, this idea was proposed as a part of #30357 (comment) but I'm splitting it off into a separate issue. This functionality is originally stemming from an item on the Improvements to Reusable blocks tracking issue (#27890), but could also work nicely when applied to Template Parts.

Within the isolated editing view for Reusable blocks and Template Parts*, it would be great if one could easily navigate to locations where the items are in use to make sure that any changes made work well in all contexts. This is sort of a reverse counterpart to the proposed popover menu shown for Templates (#29147), which has a menu of Template Part areas leading to their isolated editing views.

*Discussions around the isolated views are for each are ongoing: see #29148 and #29337, comment

Here’s how this might work for Reusable blocks:

RB-menu

And for Template Parts:

TP-menu

Quick look at if the list could scroll in instances where there are a lot of items:

RB-long-list.mov

Questions:

The design of these popover menus mirrors recent changes to the way Template descriptions are working but I wonder if we should revisit the title appearing in both the top toolbar and at the top of the popover menu so it isn't repeated twice (although probably less of an issue when the top bar is displaying the document information as well)

Does it feel like including the number with the section headings such as "Post (2)" helps with clarity, or does the "Used in 4 locations" at the top of the popover seem clear enough on its own?

Figma file here! :)

@critterverse critterverse added [Block] Template Part Affects the Template Parts Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels Apr 8, 2021
@critterverse
Copy link
Contributor Author

critterverse commented Apr 15, 2021

A relevant top bar menu exploration for Templates was shared here: #30357 (comment)

@jameskoster
Copy link
Contributor

The Editor UI has changed a bit since this issue was opened making the designs a little outdated. Rather than updating this one, I'm going to close it out in favor of the more recent #58990 which brings the data views element into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants