Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant classes to the button link #34557

Open
mkkeck opened this issue Sep 5, 2021 · 2 comments
Open

Add variant classes to the button link #34557

mkkeck opened this issue Sep 5, 2021 · 2 comments
Labels
[Block] Buttons Affects the Buttons Block [Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.

Comments

@mkkeck
Copy link

mkkeck commented Sep 5, 2021

What problem does this address?

Reading changelogs and documentations there is described that button classes and styles have to be applied to wp-block-button__link instead of wp-block-button.
But selecting for example the button variant is-style-outlined is added to the wp-block-button instead as suggested to the wp-block-button__link.

What is your proposed solution?

I think, this should be updated in documentation or the button block should be updated.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. developer-docs [Block] Buttons Affects the Buttons Block labels Sep 24, 2021
@mkaz mkaz added [Type] Developer Documentation Documentation for developers and removed developer-docs labels Nov 24, 2021
@ryanwelcher
Copy link
Contributor

@sagarnasit is going to have a look at this.

@cbirdsong
Copy link

This change would make writing CSS for alternate button styles so much easier, though at the same time I shudder to think how disruptive doing this would be to existing styles that assume the is-style- class would be applied to the wrapper element.

This also makes me question why the wrapper element would need to exist? I'd be curious to hear any historical context for why it was added in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants