Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter menu ARIA roles and attributes #3617

Closed
afercia opened this issue Nov 22, 2017 · 1 comment
Closed

Inserter menu ARIA roles and attributes #3617

afercia opened this issue Nov 22, 2017 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Nov 22, 2017

Splitting this out from #1823

The inserter is now in a stable enough state but still uses ARIA roles and attributes that where added in a first implementation, when the block types were presented in a sort of vertical list.

Testing with screen readers, it appears there's the need to make some adjustments. I think the roles menu and menuitem can stay, but there's probably the need to "flatten" the ARIA tree and use some role="presentation" on other elements. This would require some testing.

Nooticed so far:

  • JAWS 2018 and IE11 don't announce the name of the block types. They announce just "menu"
  • Firefox and NVDA incorrectly report the number of items in a category group (right now, each group is an ARIA menu), see screenshots below

Seems there's no consistency in the (wrong) number of items that gets announced:

in this case, there are 3 items but then NVDA announces "n of 4"

screenshot 13

and in this case, there are 3 items but then NVDA announces "n of 7"

screenshot 14

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Nov 22, 2017
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone Jun 4, 2018
@afercia
Copy link
Contributor Author

afercia commented Jul 16, 2018

The Inserter has been completely refactored and it’s now based on accordions. Also the ARIA part has been greatly simplified in #7058. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

2 participants