Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synced pattern title illegible when using block-based theme with dark background #37203

Closed
dcalhoun opened this issue Dec 7, 2021 · 0 comments · Fixed by #55399
Closed

Synced pattern title illegible when using block-based theme with dark background #37203

dcalhoun opened this issue Dec 7, 2021 · 0 comments · Fixed by #55399
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@dcalhoun
Copy link
Member

dcalhoun commented Dec 7, 2021

Description

When using a block based theme that includes a dark background color, the title and help icon of a Reusable block is very difficult to read.

Step-by-step reproduction instructions

  1. Set a site's theme to a block-based theme with a dark background, e.g. Geologist.
  2. Add a Reusable block to the block editor canvas.

Expected behaviour

The Reusable block title and help icon are legible.

Actual behaviour

The Reusable block title and help icon are illegible due to the low contrast ratio.

Screenshots or screen recording (optional)

Reusable block title illegible with dark background, block-based theme

WordPress information

  • WordPress version: WordPress.com
  • Gutenberg version: v12.0.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? No, Geologist.

Device information

  • Device: iPhone 13 mini
  • Operating system: iOS 15.1.1
  • WordPress app version: v18.8
@dcalhoun dcalhoun added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Dec 7, 2021
@dcalhoun dcalhoun mentioned this issue Dec 7, 2021
Merged
2 tasks
@dcalhoun dcalhoun mentioned this issue Sep 15, 2023
Open
@dcalhoun dcalhoun mentioned this issue Sep 23, 2023
Closed
@dcalhoun dcalhoun changed the title Reusable block title illegible when using block-based theme with dark background Synced pattern title illegible when using block-based theme with dark background Sep 23, 2023
@SiobhyB SiobhyB mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RNMobile] Synced Patterns: Ensure title is always visible WordPress/gutenberg
1 participant
@dcalhoun