Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum height of the cover block in Gutenberg has the unit "vw", more logical would be "vh". #37724

Closed
annagson opened this issue Jan 5, 2022 · 4 comments · Fixed by #39383
Closed

Minimum height of the cover block in Gutenberg has the unit "vw", more logical would be "vh". #37724

annagson opened this issue Jan 5, 2022 · 4 comments · Fixed by #39383
Assignees
@ntsekouras @amustaque97
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@annagson
Copy link

annagson commented Jan 5, 2022

What problem does this address?

Gutenberg block "cover": When setting the cover's minimum height, the options are: px, em, rem and vw. The latter is the width of the viewport. "vh" is not an option.

What is your proposed solution?

Add (or replace with) "vh", the height of the viewport.
@Mamaduka Mamaduka added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement. labels Jan 5, 2022
@amustaque97
Copy link
Member

Hey there! I would like to give it a shot 😄

@amustaque97 amustaque97 self-assigned this Jan 5, 2022
@chthonic-ds
Copy link
Contributor

Previous issue with likely solution: #36035

@amustaque97
Copy link
Member

Hi, @ntsekouras , I saw you're working on the PR #39145.

Could you give me some insights about this issue! Does this issue require some action item?

Thank you

@ntsekouras ntsekouras mentioned this issue Mar 11, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 11, 2022
@ntsekouras
Copy link
Contributor

👋 Thanks for creating the issue!

At first this seemed to me as duplicate of: #36035 but I created a PR with a detailed description about this here: #39383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

@amustaque97 amustaque97

Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
5 participants
@Mamaduka @ntsekouras @amustaque97 @chthonic-ds @annagson