Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block image is missing some useful settings available in the classic editor #4007

Closed
overclokk opened this issue Dec 14, 2017 · 4 comments
Closed
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.

Comments

@overclokk
Copy link

The block image is missing the size selection (and other 2 settings for alignement and image link) when you click for adding new image on the modal

gutenberg - screenshot-192 168 1 10-2017-12-14-16-57-12

This is the modal in the classic editor with the additional settings:

classic editor - screenshot-192 168 1 10-2017-12-14-17-03-03

The size selection is in the block tab settings but this means that you have to add the image and then click on the tab block and then select the size.

gutenberg block settings - screenshot-192 168 1 10-2017-12-14-17-07-43

And in the block settings tab is also missing the field for adding custom image css class and some other options (this above is the modal when you want to canghe settings on added image):

classic editor - media windows settings - screenshot-192 168 1 10-2017-12-14-17-09-18

@karmatosed
Copy link
Member

A little point but you can add a CSS class to each block so that solves the custom class issue. That said, I do think the flow makes sense, you add an image then you add treatment like CSS and alignment. Also then you can visually 'see'. I would argue that the way the existing media input works is not as user friendly.

@overclokk
Copy link
Author

A little point but you can add a CSS class to each block so that solves the custom class issue.

You can add a custom CSS class only to a block and not to image tag itself

<figure class="wp-block-image custom-css-added-from-block-tab">
    <img src="http://192.168.1.10/italystrap/wp-content/uploads/2013/03/cropped-cropped-image-alignment-1200x4002.jpg" alt="" class="css-class-added-manually" />
</figure>

You can add manually on the "Edit as HTML" but the users are not so expert to touch HTML

Also in the classic editor there is a filter that it can be used to add some default CSS class to the field: https://codex.wordpress.org/Plugin_API/Filter_Reference/get_image_tag_class it could be useful to have the same in Gutenberg.

I do think the flow makes sense, you add an image then you add treatment like CSS and alignment. Also then you can visually 'see'.

Yes, less click, better UX

I would argue that the way the existing media input works is not as user friendly.

In the classic editor or in Gutenberg?

@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media Backwards Compatibility Issues or PRs that impact backwards compatability labels Jan 23, 2018
@danielbachhuber danielbachhuber added this to the Merge Proposal: Back Compat milestone May 21, 2018
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Jul 17, 2018
@designsimply
Copy link
Member

Tested and confirmed that Attachment Display Settings are no longer present when inserting an image but all are available after the image has been inserted. (screenshots: classic, gutenberg)

  • Alignment
  • Link To
  • Size

Also confirmed that the following advanced options are no longer available when selecting edit for a previously inserted image. (screenshots: classic, gutenberg)

  • Image Title Attribute
  • Image CSS Class (now avail. in block settings as Advanced > Additional CSS Class)
  • Open link in a new tab
  • Link Rel
  • Link CSS Class

Tested with WordPress 4.9.7 and Gutenberg 3.2.0 using Firefox 61.0.1 on macOS 10.13.5.

@designsimply
Copy link
Member

Thank you for reporting this issue! Closing in favor of #7504 because it has more information about related historical changes in core.

@designsimply designsimply added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants