Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear UX for how to get out of a locked block with headings & paragraph blocks #42481

Open
annezazu opened this issue Jul 16, 2022 · 2 comments
Labels
[Feature] Block Locking The API allowing for the ability to lock/unlock blocks [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Jul 16, 2022

Description

After locking Heading or Paragraph blocks, the UX changes after hitting return where you are still within the locked experience rather than able to create a new block:

Locked heading blocks in the provided templates were super, duper frustrating. With normal heading blocks, if I press “return” at the end of a heading I get a paragraph block. With the locked headings I got stuck in the heading blocks. This felt like a major departure from typical interactions in the block editor.

&

I wanted to add a paragraph below some of the locked headings, and spacing down just added another H2 when I expected an empty paragraph.
I realized for the second post that I needed to “Insert after” to add a paragraph, and that was OK.

This was found as part of the fifteenth call for testing for the FSE Outreach Program.

cc @Mamaduka for thoughts since I know you've done so much work around locking!

Step-by-step reproduction instructions

  1. Add a heading block.
  2. Lock it (both movement and removal)
  3. Go to the end of the heading and hit return.
  4. Notice you're still in the locked heading block.

Screenshots, screen recording, code snippet

Here's a video showing headers but it also applies to paragraph blocks:

Locked.header.UX.mov

With pre-formatted and code blocks, the experience matches that of locking, in that you have to click outside of the block itself and create a new one to break out of the experience.

Environment info

  • WordPress 6.0.1
  • GB 13.6

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Block Locking The API allowing for the ability to lock/unlock blocks Needs Design Feedback Needs general design feedback. labels Jul 16, 2022
@jasmussen
Copy link
Contributor

Good ticket, yes this is confusing.

It also seems like a bug: the way things are set up now, you can only ever make a single linebreak (<br>) when hitting Shift + Enter. Enter should always take you to a new line, including in this case.

@annezazu
Copy link
Contributor Author

Noting that this came up in the twenty fifth call for testing for the FSE Outreach Program in the template vs page editing UX:

I created a new page in Site Editor > Pages and titled it ‘Resume’.

I added content such as headings and text and tried to insert a table of contents block.

I wanted to insert the table of contents block between the title and the first block, so I moved the cursor to the page title with the mouse and pressed enter, but could not move it to the content area.

When creating pages in the block editor as before, I was able to bring the cursor to the top of the content using the same operation (strictly speaking, I was able to insert a paragraph block at the beginning), so I felt that a similar UX would be fine.

cc @SaxonF and @noisysocks as you all continue iterating here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Locking The API allowing for the ability to lock/unlock blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants