Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract hook for Navigation block fallback handling #44318

Open
getdave opened this issue Sep 21, 2022 · 0 comments
Open

Extract hook for Navigation block fallback handling #44318

getdave opened this issue Sep 21, 2022 · 0 comments
Assignees
@getdave
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality

Comments

@getdave
Copy link
Contributor

getdave commented Sep 21, 2022

We've had several rounds of updates to the fallback handling for the Nav block. The edit js code is becoming very noisy and unwieldy due to the size of the useEffect.

Let's extract this to a dedicated hook which exposes the necessary information.

Related #44173
@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels Sep 21, 2022
@getdave getdave self-assigned this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@getdave