Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a clearer explanation about how "Convert to links" works & include a link to the documentation. #44615

Closed
mrfoxtalbot opened this issue Sep 30, 2022 · 8 comments · Fixed by #45394
Assignees
Labels
[Block] Navigation Affects the Navigation Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@mrfoxtalbot
Copy link

mrfoxtalbot commented Sep 30, 2022

What problem does this address?

When we select a Page List block in the navigation message and click on "Edit", we will be prompted with the following message:

Convert to links

To edit this navigation menu, convert it to single page links. This allows you to add, re-order, remove items, or edit their labels.

Note: if you add new pages to your site, you'll need to add them to your navigation menu.

Screen.Capture.on.2022-09-30.at.16-04-58.mp4

This message does not explain where the current menu comes from and could be clearer in general. It also lacks a link to the docs for more information.

What is your proposed solution?

Let's provide a clearer message that provides more context and includes a link to the support docs. Something long these lines:

Customize your navigation menu

We’ve provided a default list of all your published pages to get going quickly. If you prefer to convert that to an editable menu, click the button below. This will allow you to add, re-order, remove items, or edit their labels.

If you previously created a menu in a classic theme, you’ll have the option to import it later.

Learn more about menu management [link to documentation]

@mrfoxtalbot mrfoxtalbot added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Sep 30, 2022
@annezazu
Copy link
Contributor

cc @getdave @scruffian for awareness.

@getdave
Copy link
Contributor

getdave commented Oct 26, 2022

I'd like to find a way of capturing these small "long hanging fruit" type enhancements. Considering adding a section to the Tracking Issue with "Quick wins". Then the team can pick from these as they tackle other more complex problems.

Also these would be great candidates for "Good first issue" for new Nav block contributors.

What do you think?

@mrfoxtalbot mrfoxtalbot added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 26, 2022
@mrfoxtalbot
Copy link
Author

Thank you @getdave! Do you think we could use [Good First Issue] as a way to track these? Is it better to comment on the tracking issue and have them added to a separate section?

@artemiomorales
Copy link
Contributor

Hi all! New contributor here. I can take this on 🙂

@artemiomorales artemiomorales self-assigned this Oct 27, 2022
@artemiomorales
Copy link
Contributor

artemiomorales commented Oct 27, 2022

Hi @mrfoxtalbot, I'm looking for clarification on this line: "If you previously created a menu in a classic theme, you’ll have the option to import it later."

Does this mean that users will have the option to import menu in a later release of Gutenberg? If so, I would modify the line to be the following: "If you previously created a menu in a classic theme, you’ll have the option to import it in a later version of the Gutenberg editor."

Let me know what you think!

@artemiomorales artemiomorales added the [Status] In Progress Tracking issues with work in progress label Oct 27, 2022
@mrfoxtalbot
Copy link
Author

Hey @artemiomorales .

Does this mean that users will have the option to import menu in a later release of Gutenberg?

No. It means that, once the "Page List" block is converted to an "Editable menu", the user will be able to assign any existing menu (created via a classic theme) to that space, as seen below:

Screen Shot on 2022-10-28 at 11:58:46

Would this make sense?

@artemiomorales
Copy link
Contributor

@mrfoxtalbot

Yes, that makes sense! I've updated the copy to be the following and created a pull request:

Customize your navigation menu

We’ve provided a default list of your published pages so you can get started quickly. If you’d prefer to edit this menu, click the Convert button below — converting will allow you to add, re-order, and remove items, or edit their labels.

If you previously created a menu in a classic theme, converting will allow you to import it.

Click here to learn more about menu management.

@mrfoxtalbot
Copy link
Author

Thank you @artemiomorales!

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants