Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Part: Replace flow for footer in TT3 shows very small preview #44844

Closed
annezazu opened this issue Oct 10, 2022 · 2 comments
Closed
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

When replacing a footer template part using TT3, I noticed the template preview was basically nonexistent, making it both hard to see and hard to select.

Of note, the current header & footer patterns aren't visible right now and that's been reported here: #44843

Step-by-step reproduction instructions

  1. Use 6.1 beta 3.
  2. Activate TT3.
  3. Head to Appearance > Site Editor.
  4. Create a new footer. Save it.
  5. Select the footer > Select the three dot menu > select "replace".
  6. Notice the default TT3 footer is very tiny and hard to select/see.

Screenshots, screen recording, code snippet

Screen Shot 2022-10-10 at 7 27 28 PM

Environment info

  • WP 6.1-beta3-54428
  • No GB
  • TT3
  • Chrome 106.0.5249.61

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Oct 10, 2022
@talldan
Copy link
Contributor

talldan commented Oct 12, 2022

It looks like the Footer in TT3 only has a pattern block within it:

<!-- wp:pattern {"slug":"twentytwentythree/footer-default"} /-->

So I think the problem is around showing patterns within pattern previews, which I remember there was another bug report for.

This is the one - #39732. The linked PR does fix it when I tested (Try nested patterns previews with block editor setting), so I think this can be considered a duplicate.

@annezazu
Copy link
Contributor Author

Sweet! I trust your read there and will close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

2 participants