Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Custom CSS per Style Variation #45675

Closed
pbking opened this issue Nov 9, 2022 · 2 comments
Closed

Provide Custom CSS per Style Variation #45675

pbking opened this issue Nov 9, 2022 · 2 comments
Labels
[Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Type] Enhancement A suggestion for improvement.

Comments

@pbking
Copy link
Contributor

pbking commented Nov 9, 2022

What problem does this address?

Certain style variations may be better enhanced by having CSS that isn't appropriate for other (or some other) variations (or the base theme) to contain.

An example of this might be a "System controlled Dark Mode color scheme" variation where additional CSS is needed or variations that need CSS to achieve design targets.

What is your proposed solution?

When a style variation is activated for a theme a specific class (for instance theme-variation-VARIATION_NAME or something) is appended.

This would allow selectors to be crafted in style.css that would target only certain variations.

@pbking pbking added [Type] Enhancement A suggestion for improvement. [Feature] Block Variations Block variations, including introducing new variations and variations as a feature labels Nov 9, 2022
@carolinan
Copy link
Contributor

Hi, can I close this as a duplicate of #43405 ?

@pbking
Copy link
Contributor Author

pbking commented Nov 11, 2022

Oh thank you @carolinan yes this is a dupe, thank you for pointing out #43405

@pbking pbking closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants