Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid automated behaviours in the Navigation block when in preview mode #45887

Open
scruffian opened this issue Nov 18, 2022 · 0 comments
Open

Avoid automated behaviours in the Navigation block when in preview mode #45887

scruffian opened this issue Nov 18, 2022 · 0 comments
Labels
[Block] Navigation Affects the Navigation Block [Feature] Navigation Menus Any issue relating to Navigation Menus [Type] Enhancement A suggestion for improvement.

Comments

@scruffian
Copy link
Contributor

In #44173 we introduced a fallback to classic menus. This is also triggered when the block is previewed in a pattern browser. We should detect whether we are in a preview state, using an __unstableIsPreviewMode attribute ( introduced here), and if we are then we shouldn't import the classic menu.
@scruffian scruffian added the [Block] Navigation Affects the Navigation Block label Nov 18, 2022
@scruffian scruffian mentioned this issue Nov 18, 2022
Open
38 tasks
@getdave getdave changed the title Navigation: Classic block fallbacks: Don't import classic menus when loading a preview Avoid automated behaviours in the Navigation block when in preview mode Mar 17, 2023
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Feature] Navigation Menus Any issue relating to Navigation Menus labels Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block [Feature] Navigation Menus Any issue relating to Navigation Menus [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scruffian @jordesign