Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post isn't marked unsaved on paragraph changes #4589

Closed
pento opened this issue Jan 19, 2018 · 4 comments
Closed

Post isn't marked unsaved on paragraph changes #4589

pento opened this issue Jan 19, 2018 · 4 comments
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Milestone

Comments

@pento
Copy link
Member

pento commented Jan 19, 2018

Issue Overview

When editing a paragraph block, the post isn't marked as unsaved until the block loses focus. This allows the window to be accidentally closed, losing any changes in that paragraph.

Steps to Reproduce (for bugs)

  1. Create a new post.
  2. Add content to the first paragraph block.
  3. Click "Save Draft"
  4. Add more content to the paragraph block.

Expected Behavior

The save notification changes to "Save Draft", and triggers the "are you sure" message if you press Cmd+W.

Current Behavior

The save notification stays as "Saved", and you can close the tab without a warning that changes will be lost.

@pento pento added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention labels Jan 19, 2018
@pento pento added this to the 2.1 milestone Jan 19, 2018
@jorgefilipecosta
Copy link
Member

There was a PR created some time ago that should fix this problem #2418.

@danielbachhuber
Copy link
Member

I've experienced this problem too! I was wondering whether it was considered intentional behavior and am glad it's not :)

@karmatosed karmatosed modified the milestones: 2.1, 2.2, Merge Proposal Jan 25, 2018
@mtias
Copy link
Member

mtias commented Mar 7, 2018

This should work well now.

@mtias mtias closed this as completed Mar 7, 2018
@aduth
Copy link
Member

aduth commented Mar 7, 2018

Fixed by #4955
Duplicate of #2758, #1240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants