Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav block moving between auto menu and newly created menu lacks context #47019

Closed
getdave opened this issue Jan 10, 2023 · 5 comments
Closed

Nav block moving between auto menu and newly created menu lacks context #47019

getdave opened this issue Jan 10, 2023 · 5 comments
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] Blocked Used to indicate that a current effort isn't able to move forward

Comments

@getdave
Copy link
Contributor

getdave commented Jan 10, 2023 •
edited
Loading

As reported in #46939 (comment) moving from auto-menu (Page List menu) to having a Nav Menu created when you insert a block is confusing without context.

We need to provide context about the state change and why this happened.

This may be partly addressed by #47010, but will require additional affordences to communicate the state change as well as the current state of the "menu" currently being edit in the bloclk in terms of sync/unsynced.

Related #47020
@getdave getdave added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Navigation Affects the Navigation Block [a11y] Labelling labels Jan 10, 2023
This was referenced Jan 10, 2023
Closed
Closed
@scruffian
Copy link
Contributor

I think we should probably reconsider this in the light of #47058

@getdave
Copy link
Contributor Author

getdave commented Jan 11, 2023

But only if we can implement #47058 in time. Otherwise it's still a problem...

@scruffian scruffian mentioned this issue Jan 23, 2023
Merged
@getdave
Copy link
Contributor Author

getdave commented Jan 31, 2023

I don't consider this part of the Nav block list view work. It's a wider issue we should look to solve on the Nav block.

@scruffian
Copy link
Contributor

What happens here depends on what we do about #48625

@scruffian scruffian added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Mar 8, 2023
@scruffian scruffian mentioned this issue Mar 9, 2023
Closed
@scruffian
Copy link
Contributor

Since we have the fallback state now, I don't think this issue is relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] Blocked Used to indicate that a current effort isn't able to move forward
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scruffian @getdave @priethor