Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX feedback on working with the site editor #48443

Open
15 of 30 tasks
mtias opened this issue Feb 25, 2023 · 9 comments
Open
15 of 30 tasks

UX feedback on working with the site editor #48443

mtias opened this issue Feb 25, 2023 · 9 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@mtias
Copy link
Member

mtias commented Feb 25, 2023

These are notes from @pablohoneyhoney and myself. I'll be turning them into separate issues.

@mtias mtias added [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 25, 2023
@tresorama
Copy link

tresorama commented Feb 25, 2023

Seems a good place to add mine also.
I have plan to open dedicated issues in following days.

If this is not an appropriate place I will delete.

  • Feature - Block - Block / Spacer - should use the “theme.json” spacing scale, with fallback to custom value

Proposed Solution:
Let user defines value of height as one of these:

  • spacing scale (1-2-3-…-7 or what comes from theme.json)
  • custom value (if user want to go custom)
  • Block - Attribute - Gradient and Duotone color picker should let pick semantic token from “theme.json”

Proposed Solution:
Add Color Switcher at bottom side equal to “Solid” color

  • Block - Block / Navigation - “Block Spacing” should be renamed to “Space between items” or “Items distance” or “Items Gap”

  • Block - Block / Button - add ability to edit "hover" and "active" state

Could be good to have this also at "Editor" > "Styles" level, when user can override every default block settings.

@talldan
Copy link
Contributor

talldan commented Feb 28, 2023

Seems a good place to add mine also.
I have plan to open dedicated issues in following days.

The first one on your list has been worked on, but it has stalled somewhat - #44002.

I imagine there are also issues open somewhere for hover/active states 😄

I'm not sure about the other two suggestions, but worth checking for existing issues first.

@jameskoster
Copy link
Contributor

We should allow "Group" to have the same "full height + width of the page that cover has.

It's already possible for a Group to be full height in this way, by setting a 100vh minimum height. It's also possible for it to be full width via the alignment control. So I'm going to check that item off for now. We can easily uncheck based on the answer to the following question:

Should there be a toolbar shortcut for the full-height option as there is in the Cover block? I'd learn towards no because it seems like a feature you'd need less often in the Group context.

@porg
Copy link

porg commented Mar 22, 2023

@richtabor
Copy link
Member

Should there be a toolbar shortcut for the full-height option as there is in the Cover block? I'd learn towards no because it seems like a feature you'd need less often in the Group context.

Agreed.

@annezazu
Copy link
Contributor

👋🏼 Opened as many issues as I could from the list. A few notes on the items I didn't open issues for:

  • I cannot replicate this using the latest version of GB and 6.2 RC3: Comment navigation doesn’t have options for arrows like Next / Prev post and Post Navigation have.
  • I left this: Deleting a block with backspace seems to work only sporadically. Need to debug this.
  • I wasn't sure what was meant by this: The cover matrix alignment tends to mess up with width of the contents (align top, for example).
  • I wasn't sure what was meant by this: Could be nice to have a page number block as part of the navigation tools to display (with 1 being current)
  • I couldn't replicate any bugginess with 15.4 and 6.2 RC3: Dragging stuff out of post template is generally very error prone and makes the blocks disappear at times. Pretty frustrating experience to lose content and being forced to undo, which also feels a bit buggy.

A note for an item I linked to a currently open issue:

I added the issues opened to the Phase 2 board for tracking with best guesses for priority and areas. Feel free to rearrange, edit the issues, etc.

@jasmussen
Copy link
Contributor

Dragging stuff out of post template is generally very error prone and makes the blocks disappear at times. Pretty frustrating experience to lose content and being forced to undo, which also feels a bit buggy.

If it's what I think it is, I've been seeing this a lot, and would put a high emphasis on the importance of improving this. Here's a GIF showing dragging items in the list view:

dragging

  • It is a bit choppy
  • It is very hard to drop an item at the root level, shown in the start here, that was my goal, but the item ends up inside the header template instead
  • Occasionally it's finnicky: you click, but if you ever so slightly and accidentally drag while you click, you invoke the drag operation and suddenly the item is gone.

So a few basic suggestions that don't preclude further improvements:

  • Generally explore performance improvements, so draggin an item feels as fast as moving the cursor
  • Improve the indentation heuristic so it's much more predictable on which level you drop.
    • If that can't be done, always default to the root level, or the same level being dragged from, and allow dragging into a nesting container only by dragging on top of that container. We can even highlight the nesting container blue on hover.
  • Refine the drag invocation to either have a delay, or a minimu distance moved, so clicks don't accidentally invoke drag and drop.

@carolinan
Copy link
Contributor

(For the comment navigation, the icon option is on the parent block, Comments Pagination, not the inner Comments Previous/ Next Page blocks.)

@jasmussen
Copy link
Contributor

CC: @WordPress/gutenberg-design for visibility, there's a lot of good stuff here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
Projects
None yet
Development

No branches or pull requests

9 participants