Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove !important annotation for duotone filters #49171

Closed
ajlende opened this issue Mar 17, 2023 · 1 comment
Closed

Remove !important annotation for duotone filters #49171

ajlende opened this issue Mar 17, 2023 · 1 comment
Assignees
@jeryj
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.

Comments

@ajlende
Copy link
Contributor

ajlende commented Mar 17, 2023 •
edited
Loading

With the changes in #49103, it may be possible to remove the !important annotation since ordering is now handled in one place.

We need to investigate if it's still important to make block-level filters (applied via the toolbar in the editor) actually !important. The classes generated by color presets, for example, include the !important annotation for the .has-slug-color classes. And it may be good to follow suit even though dutone classes are not generated the same way.

Global styles (theme.json styles section) don't have the !important annotation, so at least those cases can have the annotation removed.

See #49103 (comment)
@ajlende ajlende mentioned this issue Mar 17, 2023
Open
14 tasks
@Thelmachido Thelmachido added [Type] Enhancement A suggestion for improvement. [Feature] Media Anything that impacts the experience of managing media CSS Styling Related to editor and front end styles, CSS-specific issues. labels Mar 20, 2023
@jeryj jeryj mentioned this issue Mar 21, 2023
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 21, 2023
@scruffian
Copy link
Contributor

I think this can be closed.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeryj jeryj

Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove !important declaration for duotone CSS WordPress/gutenberg
5 participants
@scruffian @jeryj @ajlende @priethor @Thelmachido