Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse mode: Add snackbar notices #50175

Closed
scruffian opened this issue Apr 28, 2023 · 7 comments
Closed

Browse mode: Add snackbar notices #50175

scruffian opened this issue Apr 28, 2023 · 7 comments
Labels
Needs Design Feedback Needs general design feedback. [Package] Notices /packages/notices

Comments

@scruffian
Copy link
Contributor

scruffian commented Apr 28, 2023

What problem does this address?

We have removed snackbar notices from the Site Editor when in browse mode here. We need these notices to allow us to show a notice when switching to a theme (see #50030).

What is your proposed solution?

The problem is that these notices are too hard to see because they are low contrast. We should move them to the center of the browser window like this:

Screenshot 2023-04-28 at 15 21 46

This was suggested by @richtabor

@scruffian scruffian added Needs Design Needs design efforts. [Package] Notices /packages/notices Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Apr 28, 2023
@jasmussen
Copy link
Contributor

I think there's an opportunity to include snackbar notices in the theming conversations, potentially applying just a lighter gray to them. But it sems fine to move them to the center as well.

@richtabor
Copy link
Member

I thought we discussed somewhere to try centering them anyhow, to reduce the visual conflicts. cc @jameskoster

@jameskoster
Copy link
Contributor

Without an in-depth exploration, I'd +1 using a lighter gray as a short-term remedy.

But in general it may be worth giving the Snackbar component a design audit given the introduction of the site view. Some top-of-mind questions:

  • Should appearance be consistent across light/dark themes, or not? What are the principles there?
  • How is the dismiss affordance working alongside other actions? Should there be a dedicated close button/icon? There's something about the entirely element receiving focus then disappearing that feels a bit strange.
  • Is the current timeout still appropriate?
  • Elevation – what is the relationship with the Frame?
  • Position – bottom center vs bottom left.
  • Animation – Fadeout on dismissal is a bit slow.
  • Should we provide affordances for error snackbars (red background, decorative icon)?

@scruffian
Copy link
Contributor Author

I did a quick fix here: #50794

@scruffian
Copy link
Contributor Author

Closed by #50794

@okmttdhr
Copy link
Contributor

okmttdhr commented Jun 6, 2023

The initial PR #50794 was reverted by #50937, but the problem was solved in #51054 again (c.f. #51054 (comment) and #51054 (comment)).

So, I believe this issue has now been solved.

@scruffian
Copy link
Contributor Author

Yes, looks like this can be closed, thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Package] Notices /packages/notices
Projects
None yet
Development

No branches or pull requests

6 participants