Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Previews: Remove code from the editor package #50177

Closed
scruffian opened this issue Apr 28, 2023 · 0 comments · Fixed by #50863
Closed

Theme Previews: Remove code from the editor package #50177

scruffian opened this issue Apr 28, 2023 · 0 comments · Fixed by #50863
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@scruffian
Copy link
Contributor

What problem does this address?

In Add Theme Previews for block themes we added code for Themes Previews to the editor package, which doesn't belong there.

What is your proposed solution?

We need to find a way to extract this to the edit-site package so that the editor package is kept clear of these concerns.
@scruffian scruffian added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Apr 28, 2023
@scruffian scruffian mentioned this issue Apr 28, 2023
Merged
15 tasks
@okmttdhr okmttdhr mentioned this issue May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract BlockThemePreviews-related code from the editor package okmttdhr/gutenberg
2 participants
@scruffian and others