Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a CheckboxControl for the Opens in new tab control in Link Control. #50947

Closed
Tracked by #50890
getdave opened this issue May 25, 2023 · 0 comments · Fixed by #50961
Closed
Tracked by #50890

Use a CheckboxControl for the Opens in new tab control in Link Control. #50947

getdave opened this issue May 25, 2023 · 0 comments · Fixed by #50961
Assignees
@getdave
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)

Comments

@getdave
Copy link
Contributor

getdave commented May 25, 2023 •
edited
Loading

As per #50890 let's use a checkbox for the Opens in new tab control. This better communicates to a user that they must submit the control itself before this setting will be persisted.

This relies on #50945 to be completed.
@getdave getdave mentioned this issue May 25, 2023
Closed
8 tasks
@getdave getdave added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label May 25, 2023
@getdave getdave mentioned this issue May 25, 2023
Closed
@getdave getdave changed the title Use a CheckboxControl for the new tab control. Use a CheckboxControl for the Opens in new tab control in Link Control. May 25, 2023
This was referenced May 25, 2023
Merged
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 25, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use checkbox for Open in new tab within Link Control WordPress/gutenberg
2 participants
@getdave @priethor