Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Inserter experience when editing pages in the Site Editor #51538

Closed
jameskoster opened this issue Jun 15, 2023 · 3 comments
Closed
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback.

Comments

@jameskoster
Copy link
Contributor

There are a couple of issues it would be nice to address in the page edit experience in the site editor.

  1. If you open the Inserter without first selecting the Post Content block it appears totally empty.
  2. Dragging blocks from the Inserter to the canvas does nothing, despite the UI hinting that it will via cursor: copy.
Screenshot 2023-06-15 at 14 41 53

For the first issue, I understand this is because blocks cannot be added to the template when you're page editing. But the empty Inserter is a bit unexpected. We might try adding a notice that explains the situation, or alternatively: display the blocks and add some logic so that they get added as child blocks of Post Content on click.

For the second issue, perhaps a modal could appear if you drop a block outside of Post Content, explaining why you cannot do that, and providing a link to go edit the template. Alternatively we could just use cursor: no-drop on incompatible regions — this would be more elegant, but potentially confusing ("Why can't I drop this block here?").

cc @SaxonF @noisysocks since y'all worked on this and may have additional context.

@jameskoster jameskoster added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 15, 2023
@jameskoster
Copy link
Contributor Author

@richtabor potentially one for UX & Polish?

@SaxonF
Copy link
Contributor

SaxonF commented Jun 16, 2023

We have inserter behaviour as a follow up task here. I've linked it to this post for further context.

@jameskoster
Copy link
Contributor Author

Inserter is no longer empty when editing a page in the site editor which was the main issue here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback.
Projects
Status: Done
Development

No branches or pull requests

2 participants